Skip to content

Fix for issue #109 - After uploading a video the thumbnail is missing#121

Open
bluengreen wants to merge 2 commits intoassembler:masterfrom
bluengreen:master
Open

Fix for issue #109 - After uploading a video the thumbnail is missing#121
bluengreen wants to merge 2 commits intoassembler:masterfrom
bluengreen:master

Conversation

@bluengreen
Copy link
Copy Markdown

Added resource_type to $cloudinary.url call to get correct url for video thumbnails

@bluengreen bluengreen changed the title Fix for #109 Fix for issue #109 - After uploading a video the thumbnail is missing Jan 5, 2016
@orlando
Copy link
Copy Markdown
Collaborator

orlando commented Jan 5, 2016

Hey @bluengreen can we add a small test for this please?

Also, what about squashing these commits?

Thanks!

@bluengreen
Copy link
Copy Markdown
Author

Is there an existing test for that code?

@orlando
Copy link
Copy Markdown
Collaborator

orlando commented Jan 6, 2016

I don't think we have a test for the thumbnail generation. I'll say that is fine add this to https://github.com/assembler/attachinary/blob/master/spec/features/notes_spec.rb.

Also if you can add a bit of context to this PR, I know that cloudinary defaults to resource_type: image, but why we are doing this instead of using resource_type: auto for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants