default FileMixin#as_json options argument to nil#141
Open
AlexWheeler wants to merge 1 commit intoassembler:masterfrom
AlexWheeler:default-as-json-argument-to-nil
Open
default FileMixin#as_json options argument to nil#141AlexWheeler wants to merge 1 commit intoassembler:masterfrom AlexWheeler:default-as-json-argument-to-nil
AlexWheeler wants to merge 1 commit intoassembler:masterfrom
AlexWheeler:default-as-json-argument-to-nil
Conversation
* active_support expects a method that optionally accepts options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #142
as_jsonto optionally accept an options hash argumentline 93 in https://github.com/rails/rails/blob/master/activesupport/lib/active_support/json/encoding.rb calls as_json without an argument so this breaks when trying to jsonify an attachinary file instance