Test fix#152
Closed
fabn wants to merge 29 commits intoassembler:masterfrom
Closed
Conversation
This conversion is done by Transpec 3.3.0 with the following command:
transpec -f
* 38 conversions
from: obj.should
to: expect(obj).to
* 19 conversions
from: == expected
to: eq(expected)
* 6 conversions
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
* 4 conversions
from: it { should_not ... }
to: it { is_expected.not_to ... }
* 2 conversions
from: =~ /pattern/
to: match(/pattern/)
* 2 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 1 conversion
from: obj.should_not_receive(:message)
to: expect(obj).not_to receive(:message)
* 1 conversion
from: obj.stub(:message)
to: allow(obj).to receive(:message)
For more details: https://github.com/yujinakayama/transpec#supported-conversions
…ng in travis until I found a working config for headless testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I restored test execution and integrated them with travis. I needed this because currently it's not possible to upgrade to rails 5.1 with the current gem version.
This could be a starting point to integrate some open pull requests and try to ensure nothing brokes.
Currently I used my travis account with my cloudinary account encrypted in file
cloudinary.yml.enc, if you want to merge this into master you should configure your account there to run javascript integration tests.Non js tests are run using vcr, so every
cloudinary.ymlfile with valid credentials will work.Next steps could be:
After this we can move on and try to support Rails 5 and later cloudinary versions and integrate them with Travis build matrix.
Let me know if you're interested in this and I'll try to move on.
Fix #82, #83 and possibly other issues.