Use a dedicated chrome color for the tab bar background - #185
Merged
Conversation
The tab bar and inactive tabs painted themselves with the ANSI black palette entry, which is a dark slab in both themes — correct as a terminal color, wrong as a surface. Under solarized light it left the sidebar dark against the cream terminal pane. Add a `surface` field to TerminalTheme for chrome backgrounds: base02 in dark (identical to what black was giving us, so dark is unchanged) and base2 in light, one step off the cream bg. The active tab still uses bg, so it reads as continuous with the terminal pane either way. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xfy2d1rVn6KLES1emwQPWJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tab bar and inactive tabs painted themselves with the ANSI black palette entry, which is a dark slab in both themes — correct as a terminal color, wrong as a surface. Under solarized light that left the sidebar dark against the cream terminal pane.
This adds a
surfacefield toTerminalThemefor chrome backgrounds: base02 in dark, which is exactly whatblackwas already giving us so the dark theme is pixel-identical, and base2 in light, one step off the creambg. The active tab keeps usingbg, so it still reads as continuous with the terminal pane in both themes. The ANSI palette itself is untouched — it was already correct for solarized light.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xfy2d1rVn6KLES1emwQPWJ