fix: support slash-based branches and multi-dot filenames in URL parsing#2155
Open
lwl2005 wants to merge 2 commits into
Open
fix: support slash-based branches and multi-dot filenames in URL parsing#2155lwl2005 wants to merge 2 commits into
lwl2005 wants to merge 2 commits into
Conversation
Handle cases where the file name may not contain an extension.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #1940
Changes
1. GitHub URL Parsing - Support slash-based branches
([^\/]+)to(.+)for branch name matchingfeature/new-validation2. File Extension Detection - Support multi-dot filenames
name.split('.')[1]toname.includes('.') ? name.split('.').pop() : ''my.asyncapi.yaml(returnsyamlinstead ofasyncapi)Testing
https://github.com/org/repo/blob/feature/new-validation/spec.yamlnow parse correctlymy.asyncapi.yamlnow detect extension asyaml