You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds unit test coverage for SettingsService in apps/studio/src/services/tests/settings.service.test.ts.
Tests .get() to verify accurate retrieval of the default SettingsState (both governance flags and templates configuration).
Tests .set() to ensure partial updates to templates and nested governance properties update the store correctly while leaving untouched properties intact.
Tests .isEqual() to ensure accurate deep equality comparisons against identical and modified settings states.
Implements afterEach teardown resetting the store back to defaultState between tests to guarantee test isolation.
Verified workspace code quality via turbo run lint (passed with 0 errors, 0 warnings).
Related issue(s)
Relates to #1246 (Part of #1246 - adding unit test coverage for services)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request. Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Description
SettingsServiceinapps/studio/src/services/tests/settings.service.test.ts..get()to verify accurate retrieval of the defaultSettingsState(bothgovernanceflags andtemplatesconfiguration)..set()to ensure partial updates totemplatesand nestedgovernanceproperties update the store correctly while leaving untouched properties intact..isEqual()to ensure accurate deep equality comparisons against identical and modified settings states.afterEachteardown resetting the store back todefaultStatebetween tests to guarantee test isolation.turbo run lint(passed with 0 errors, 0 warnings).Related issue(s)
Relates to #1246 (Part of #1246 - adding unit test coverage for services)