VariableThinMultipole set default amplitudes and default freq and phase for SINE mode - #1118
Open
oscarxblanco wants to merge 2 commits into
Open
VariableThinMultipole set default amplitudes and default freq and phase for SINE mode#1118oscarxblanco wants to merge 2 commits into
oscarxblanco wants to merge 2 commits into
Conversation
Contributor
Author
|
Dear @lfarv and @swhite2401 , this implements the default behaviour of the VariableThinMultipole mentioned in #1117 (review) in order to solve the printing issue. Could you please review this PR ? |
Contributor
Author
|
Here is the default definition of the element |
Contributor
Author
|
And this is the default output in the terminal |
oscarxblanco
changed the title
Contributor
Author
|
Dear @lfarv , here is a temporary solution to issue #1120 . The atvariablethinmultipole is now created without errors @swhite2401 asked to have a buffer for the white noise. |
oscarxblanco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the default AmplitudeB, FrequencyB and PhaseB for the default mode at.ACMode.SINE of the VariableThinMultipole in pyat.
A function called _default_amplitudes sets the default behaviour.
The MaxOrder definition has been moved and reorganized to give priority to the user MaxOrder.
A bug in the _set_amplitudes for AmplitudeA has been fixed.
The default frequency for the at.ACMode.SINE is set to zero.