Gcc16 - #1146
Merged
Merged
Conversation
olemke
reviewed
Jul 15, 2026
olemke
reviewed
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes the formatting system in ARTS work with GCC16.
There is a change I cannot identify between GCC15 and GCC16 where raw characters, and their arrays are not treated correctly. Raw
charbecomesint, so' 'prints as32. Rawchar[]arrays (probably alsoconst char *but I never tested), also has their problems in that they keep the\0in the generated string (so it secretly prints to files, which is only caught when programmatically parsing the file again.)Anyways, the updated code explicitly makes these illegal. Your code will not compile when you try to put raw characters into the formatter. The error for
tags.format(ctx, v.numer, "/", v.denom);reads (at the bottom):• the expression '(... && no_raw_chars<Rest>) [with Rest = {char[2], long long int}]' evaluated to 'false'which might sound cryptic but the exact line is marked in your custom formatter. So hopefully seeing "no_raw_chars" and the exact function call will be enough to understand the bug. Sadly, all the formatter code is templated so the error message will appear late in the compilation process.