fix(maps): repair non-enterable authored exits - #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair the current authored map changes that remove the statically detected
non-enterable exit destinations from the content corpus. This addresses the
content-repair work tracked by content#256
and is separate from the strict validator gate in
content#258.
The nine modified maps remove 28 of the 30 findings currently reported by the
strict scan. The two remaining edge-stair findings depend on restoring
filename-based automatic tiling in
classic#525 and are documented
below rather than hidden by this PR.
Implementation / behavior
last_heal 0so they do not inherit an automatic tiled-exit destination.and its associated sign.
canonical ordering of affected metadata records.
Validation
python3 tools/validate_exits.py --json— reports exactly two remainingdiagnostics, both the filename-tiling edge cases listed below.
python3 tools/validate.py— content parsing, release parity, and 175 testspass; the current
mainbaseline then rejects 28 stale baseline entries,which is expected to disappear when strict validator PR fix(validation): enforce strict authored exit checks #258 removes the
baseline mechanism.
git diff --check— passed.Limitations / follow-up
The following two findings intentionally remain until Classic automatic tiling
is restored and the validator is aligned with that runtime behavior:
/shattered_islands/world_1_50:2571,(19,23), facing south, resolves to/shattered_islands/world_1_50_-1at(19,24)./shattered_islands/world_2_47:105,(0,15), facing west, resolves to/shattered_islands/world_2_47_-1at(-1,15).This draft should converge with classic#525
and content#258 before the strict
content gate is expected to report zero findings.
Refs content#256