fix(formatters): pin Locale.ROOT on every COBOL date formatter#42
fix(formatters): pin Locale.ROOT on every COBOL date formatter#42
Conversation
Closes #16. DateTimeFormatter.ofPattern(...) without an explicit locale uses the JVM default locale, which can emit non-ASCII digits under some locales. Any such output going into PROCTRAN.DESCRIPTION would corrupt the COBOL-shaped audit-trail text. Audit of the codebase found seven formatters still missing a pinned locale. All seven now use Locale.ROOT: - CreaccRepository.COBOL_DATE_FORMATTER (ddMMyyyy) - CrecustRepository.PROCTRAN_DOB_FORMATTER (dd/MM/yyyy) - CrecustService.COBOL_DATE_FORMATTER (ddMMuuuu, used for parsing) - InqacccuController.COBOL_DATE_FORMATTER (ddMMyyyy) - CrecustController.COBOL_DATE_FORMATTER (ddMMyyyy) - CreaccController.COBOL_DATE_FORMATTER (ddMMyyyy) - InqaccController.COBOL_DATE_FORMATTER (ddMMyyyy) The formatters in UpdcustRepository, DelcusRepository, DelaccRepository, DelcusController, DelaccController, UpdaccController, UpdcustController already pinned Locale.ROOT and are unchanged.
![augment-app-staging[bot]](https://avatars.githubusercontent.com/in/1008152?s=60&v=4){kind=small}
|
|
||
| private static final DateTimeFormatter COBOL_DATE_FORMATTER = | ||
| DateTimeFormatter.ofPattern("ddMMuuuu").withResolverStyle(ResolverStyle.STRICT); | ||
| DateTimeFormatter.ofPattern("ddMMuuuu", Locale.ROOT).withResolverStyle(ResolverStyle.STRICT); |
There was a problem hiding this comment.
Since COBOL_DATE_FORMATTER is now pinned to Locale.ROOT, parseDateOfBirth’s String.format("%08d", cobolDate) can still produce locale-specific digits under some JVM locales, which would then fail to parse against the ROOT formatter.
This could change behavior in non-ASCII-digit locales (DOBs that previously parsed may now be rejected).
Severity: high
🤖 Was this useful? React with 👍 or 👎
| private static final String GLOBAL_CONTROL_ID = "GLOBAL"; | ||
| private static final DateTimeFormatter PROCTRAN_DOB_FORMATTER = DateTimeFormatter.ofPattern("dd/MM/yyyy"); | ||
| private static final DateTimeFormatter PROCTRAN_DOB_FORMATTER = | ||
| DateTimeFormatter.ofPattern("dd/MM/yyyy", Locale.ROOT); |
There was a problem hiding this comment.
Even with PROCTRAN_DOB_FORMATTER pinned to Locale.ROOT, toDescription still uses String.format(...) without an explicit locale for the customer number, which can emit non-ASCII digits under some JVM locales.
That means PROCTRAN.DESCRIPTION could still be corrupted in the same scenarios this PR is trying to prevent.
Severity: high
🤖 Was this useful? React with 👍 or 👎
Round-1 review on #42 caught two String.format calls that still relied on the JVM default locale, undermining the formatter pinning: 1. CrecustRepository.toDescription used String.format(\%010d\, ...) and String.format(\%-14.14s\, ...) for the customer-number and name slots of PROCTRAN.DESCRIPTION. Under a non-ASCII-digit JVM locale, the customer number could be emitted with non-ASCII digits, corrupting the COBOL-shaped audit-trail text \u2014 the very thing the PROCTRAN_DOB_FORMATTER pinning was meant to prevent. 2. CrecustService.parseDateOfBirth used String.format(\%08d\, ...) to normalize the int DOB before parsing it through the now-ROOT-pinned COBOL_DATE_FORMATTER. Under a non-ASCII-digit locale the normalized string would not match the ROOT formatter, so DOBs that previously parsed would now be rejected. Both calls now pass Locale.ROOT explicitly, matching the existing DELCUS / DELACC / CREACC / UPDCUST repository conventions.
|
Round-1 review addressed:
No other unpinned Local augment review |
1 participant
Closes #16.
What
DateTimeFormatter.ofPattern(...)without an explicit locale uses the JVM default locale, which can emit non-ASCII digits (e.g. Eastern Arabic) under some locales. Any such output going intoPROCTRAN.DESCRIPTIONwould corrupt the COBOL-shaped audit-trail text.Audit of the codebase found seven formatters still missing a pinned locale. All seven now use
Locale.ROOT:Repository:
CreaccRepository.COBOL_DATE_FORMATTER(ddMMyyyy)CrecustRepository.PROCTRAN_DOB_FORMATTER(dd/MM/yyyy)Service:
CrecustService.COBOL_DATE_FORMATTER(ddMMuuuu, used to parse the request DOB; locale-independent for digits but pinned for consistency)Controllers:
InqacccuController.COBOL_DATE_FORMATTER(ddMMyyyy)CrecustController.COBOL_DATE_FORMATTER(ddMMyyyy)CreaccController.COBOL_DATE_FORMATTER(ddMMyyyy)InqaccController.COBOL_DATE_FORMATTER(ddMMyyyy)The formatters in
UpdcustRepository,DelcusRepository,DelaccRepository,DelcusController,DelaccController,UpdaccController,UpdcustControlleralready pinnedLocale.ROOTand are unchanged.Tests
Behaviour is unchanged when running under an ASCII-digit locale (the CI default), so existing tests still cover the pre/post behaviour. Local
./mvnw verifygreen: 198/198.augment review