test: add revision tests - #3257
Open
miparnisari wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
miparnisari
force-pushed
the
moar-tests
branch
2 times, most recently
from
August 4, 2026 16:34
c9f6173 to
4231fe9
Compare
miparnisari
force-pushed
the
moar-tests
branch
2 times, most recently
from
August 4, 2026 20:46
21e4bd0 to
dae9d1e
Compare
miparnisari
force-pushed
the
moar-tests
branch
from
August 21, 2026 17:41
dae9d1e to
0d23213
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
github-actions
Bot
added
area/datastore
miparnisari
force-pushed
the
moar-tests
branch
from
August 21, 2026 18:51
f3a731f to
fea8f41
Compare
tstirrat15
previously approved these changes
Aug 21, 2026
tstirrat15
left a comment
tstirrat15
left a comment
Contributor
There was a problem hiding this comment.
LGTM pending fixing that test
| require.EventuallyWithT(t, func(collect *assert.CollectT) { | ||
| instancesClient, err := instances.NewInstanceAdminClient(ctx) | ||
| if !assert.NoError(t, err) { | ||
| if !assert.NoError(collect, err) { |
miparnisari
force-pushed
the
moar-tests
branch
2 times, most recently
from
August 28, 2026 18:42
9ca8bf4 to
0025b29
Compare
miparnisari
force-pushed
the
moar-tests
branch
from
August 28, 2026 18:56
0025b29 to
d027619
Compare
miparnisari
force-pushed
the
moar-tests
branch
from
August 28, 2026 19:07
c8572de to
85a0680
Compare
miparnisari
commented
Aug 28, 2026
| listen_addresses = '*' | ||
| max_connections = 3000 | ||
| track_commit_timestamp = 1 | ||
| autovacuum=off No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
FYI when we moved to Testcontainers, we lost this. #3163 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TestQuantizedRevisionStaysReadablewhich was broken on SpannergcWindowconfig)TestSnapshotReadStabilitywhich was broken onmemdbTestReadYourWritesandTestReadYourConcurrentWrites