fix: distinguish completed and unresumable backup files#694
Open
ivanauth wants to merge 1 commit into
Open
Conversation
Cursor() inferred "completed" from a missing .lock, but .lock is only written on the first Append — so a backup that crashed before the first relationship was misreported as completed and refused to resume. Add a .done sentinel written on successful Close. Cursor returns the cursor when .lock exists, ErrBackupAlreadyCompleted when only .done does, ErrBackupUnresumable when neither. Close writes .done before removing .lock. NewFileEncoder clears stale sidecars on fresh open.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
+ Coverage 43.77% 43.97% +0.20%
==========================================
Files 38 38
Lines 6193 6212 +19
==========================================
+ Hits 2711 2732 +21
+ Misses 3201 3195 -6
- Partials 281 285 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OcfFileEncoder.Cursor()inferred "completed" from a missing.lock, but.lockis only written on the firstAppend()— so a backup that crashed before the first relationship was misreported as completed and refused to resume.Add a
.donesentinel written on successfulClose().Cursor()now returns the cursor when.lockexists,ErrBackupAlreadyCompletedwhen only.donedoes, andErrBackupUnresumablewhen neither.Close()writes.donebefore removing.lock.NewFileEncoderclears stale sidecars on fresh open.