fix: restore package-type Image branching (regression in v1.1.1)#73
Open
JamBalaya56562 wants to merge 1 commit intoaws-actions:mainfrom
Open
fix: restore package-type Image branching (regression in v1.1.1)#73JamBalaya56562 wants to merge 1 commit intoaws-actions:mainfrom
JamBalaya56562 wants to merge 1 commit intoaws-actions:mainfrom
Conversation
The durable-functions refactor (aws-actions#65) removed the package-type branching in run(), createFunction, and updateFunctionCode, so Image deployments now fail unconditionally with: Packaging code artifacts from Failed to package artifacts: Code artifacts directory path must be provided because packageCodeArtifacts() is called even when no code-artifacts-dir is configured. This restores the v1.1.0 behavior: - run() skips packageCodeArtifacts when packageType === 'Image' - createFunction sends Code: { ImageUri } and PackageType: 'Image', and omits Runtime / Handler / Layers for Image - createFunction includes ImageConfig only for Image - updateFunctionCode sends ImageUri instead of ZipFile for Image - updateFunctionConfiguration omits Handler / Runtime / Layers for Image and includes ImageConfig only for Image - hasConfigurationChanged uses the same gating - the PackageType-change guard is restored - durable-functions config from aws-actions#65 is preserved unchanged Adds a regression test that exercises the real createFunction and updateFunctionCode with package-type: Image and asserts that ImageUri is sent and that ZipFile / Runtime / Handler / Layers are not. Fixes aws-actions#70.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The durable-functions refactor (#65) removed the package-type branching
in run(), createFunction, and updateFunctionCode, so Image deployments
now fail unconditionally with:
because packageCodeArtifacts() is called even when no
code-artifacts-dir is configured.
This restores the v1.1.0 behavior:
and omits Runtime / Handler / Layers for Image
Image and includes ImageConfig only for Image
Adds a regression test that exercises the real createFunction and
updateFunctionCode with package-type: Image and asserts that ImageUri
is sent and that ZipFile / Runtime / Handler / Layers are not.
Fixes #70.