feat: Support pod-level standard fields on all managed CRs

[miconeilaws]

Summary

Adds the standard EKS addon pod-level configuration fields to the operator-managed CRs so that the amazon-cloudwatch-observability Helm chart / EKS addon can wire them all the way through to the underlying pods. Required by the EKS addon build standards taking effect end of Q3 2026.

Companion Helm chart change: aws-observability/helm-charts#364

Changes

API (source of truth — Go types)

AmazonCloudWatchAgent (apis/v1alpha1/amazoncloudwatchagent_types.go)

• Adds Spec.PodLabels (map[string]string). Merged into managed workload pod template labels; operator-reserved selector labels are preserved.

DcgmExporter (apis/v1alpha1/dcgmexpoter_types.go) and NeuronMonitor (apis/v1alpha1/neuronmonitor_types.go)

• Adds Spec.PodAnnotations, Spec.PodLabels, Spec.TopologySpreadConstraints, Spec.PriorityClassName, and Spec.PodDisruptionBudget. Reuses the existing PodDisruptionBudgetSpec type from the CWA API.

Reconcile logic

AmazonCloudWatchAgent:

• internal/manifests/collector/annotations.go — new PodLabels(instance, base) helper.
• internal/manifests/collector/{daemonset,deployment,statefulset}.go — pod template metadata.labels now composed via PodLabels() so Spec.PodLabels is applied while operator-managed selector labels (app.kubernetes.io/*) still win.
• Bug fix: daemonset.go now applies Spec.TopologySpreadConstraints. Previously the field existed in the schema but was silently dropped for DaemonSet mode (Deployment and StatefulSet already honored it).

DcgmExporter / NeuronMonitor:

• annotations.go — new PodAnnotations() and PodLabels() helpers, mirroring the CWA collector helpers (metadata-annotation inheritance + config sha256 preservation).
• daemonset.go — pod template now sets Labels via PodLabels(), Annotations via PodAnnotations(), and pod spec now propagates PriorityClassName and TopologySpreadConstraints.
• New poddisruptionbudget.go builds a policy/v1 PodDisruptionBudget when Spec.PodDisruptionBudget is set (returns nil otherwise, matching the collector behavior).
• {dcgmexporter,neuronmonitor}.go — PodDisruptionBudget added to the factory list in Build().

Deep-copy

apis/v1alpha1/zz_generated.deepcopy.go — deep-copy blocks added for all new fields, matching controller-gen output patterns (nil-check + explicit copy for maps, slices with DeepCopyInto, and pointer to PodDisruptionBudgetSpec).

Tests

• internal/manifests/collector/daemonset_test.go — TestDaemonsetPodLabels, TestDaemonsetPodLabelsCannotOverrideSelectorLabels, TestDaemonsetTopologySpreadConstraints.
  • Note: this file has a pre-existing //go:build ignore_test constraint (not introduced by this PR) that keeps its contents out of the default test binary. Recommend removing that constraint in a follow-up.
• internal/manifests/dcgmexporter/daemonset_test.go — new file, four tests covering PodLabels, PodAnnotations, TopologySpreadConstraints, PriorityClassName propagation.
• internal/manifests/dcgmexporter/poddisruptionbudget_test.go — new file, three tests (nil-skip, MinAvailable int, MaxUnavailable percent).
• internal/manifests/neuronmonitor/{daemonset,poddisruptionbudget}_test.go — parallel to DCGM.

Not included — needs a maintainer with public Go module network access

The following require running make generate && make manifests from a machine that can reach proxy.golang.org (the environment where this PR was authored has that endpoint blocked):

1. CRD YAML regeneration — config/crd/bases/{amazoncloudwatchagents,dcgmexporters,neuronmonitors}.yaml need the new fields added. Without this, the API server will reject CRs that set the new fields.
2. Bundle/api-docs — bundle/, docs/api.md, config/ may need regen. make ensure-generate-is-noop will flag this.

I hand-updated apis/v1alpha1/zz_generated.deepcopy.go because those blocks are mechanical and reviewable — but the CRD YAMLs are large and better regenerated authoritatively. Happy to push a follow-up commit with the regen output if a maintainer runs make generate manifests and shares the diff, or run it myself once we have network access sorted.

Companion Helm chart PR

aws-observability/helm-charts#364 — introduces top-level podLabels, podAnnotations, topologySpreadConstraints, priorityClassName, and podDisruptionBudget values wired into the operator CRs. Once this operator PR merges and a new operator image ships, the Helm chart PR's "known limitations" section (podLabels on CWA; all 5 fields on DcgmExporter / NeuronMonitor) can be dropped and the CR templates can pass those fields through.