fix cloudwatchlogs flaky tests - #754
Open
Paamicky wants to merge 6 commits into
Open
Conversation
Paamicky
force-pushed
the
mcommey/fix-cloudwtch-logs-flaky-tests
branch
from
September 2, 2026 23:08
00c5ced to
04ba75a
Compare
Paamicky
changed the base branch from
main
to
fix/loggroupclass-flaky-isloggroupexists-retry
September 3, 2026 16:17
Paamicky
changed the base branch from
fix/loggroupclass-flaky-isloggroupexists-retry
to
main
September 3, 2026 16:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
Two CloudWatch Logs tests are intermittently flaky because each validates once, right after the agent acts, with no retry for CloudWatch's propagation lag.
TestWriteLogsToCloudWatchfails its exact count assertion whenGetLogsSince(which only retries on ResourceNotFoundException) queries a stream whose events haven't surfaced yet.TestLogGroupClassfailsIsLogGroupExists(...)because DescribeLogGroups is eventually consistent and can return empty right after the group is created.Description of changes
awsservice.ValidateLogsWithRetry, a bounded re-validation wrapper aroundValidateLogsthat absorbs CloudWatch propagation delay without faking a passIsLogGroupExistsWithRetry(pollsIsLogGroupExists, bounded byattempts/interval) and use it inTestLogGroupClasswith 6 attempts at 15s.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests generator cloudwatchlogs-only matrix
Note
AL2023 failure is an environment issue and will be fixed on a different PR