Skip to content

Add on premise support to identity transform - #2262

Open
jefchien wants to merge 1 commit into
mainfrom
onprem-identity
Open

Add on premise support to identity transform#2262
jefchien wants to merge 1 commit into
mainfrom
onprem-identity

Conversation

@jefchien

Copy link
Copy Markdown
Contributor

Description of changes

Adds an on-prem fallback identity for the deployment.environment.name resource attribute mirroring Application Signals. A new transform_identity_fallback.yaml is used for the host mode fallback (onPrem/onPremise + any unrecognized mode). It sets the default service.name and sets deployment.environment.name to generic:default (like Application Signals). For on-prem k8s, added a new transform statement to fallback on k8s:{{k8s.cluster.name}}/{{k8s.namespace.name}} when no cloud.platform is defined (again matching Application Signals).

EC2 identity is now its own case, so the cloud.platform == "aws_ec2" guard is dropped in its transform YAML. This change + the on-prem k8s transform statement resulted in a lot of sample config YAML changes.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Updated unit tests and added an onPrem test case.

Requirements

Before commiting your code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

Integration Tests

To run integration tests against this PR, add the ready for testing label.

@jefchien
jefchien requested a review from a team as a code owner August 28, 2026 23:02
@github-actions

Copy link
Copy Markdown
Contributor

Binary Size Report

linux/amd64

Binary PR vs main (0b21e7a) vs v1.300072.0
amazon-cloudwatch-agent 194.8 MB +0 B ${\color{red}▲}$ +1.5 MB (+0.8%)
amazon-cloudwatch-agent-config-wizard 2.0 MB +0 B +0 B
config-downloader 2.0 MB +0 B +0 B
config-translator 2.0 MB +0 B +0 B
start-amazon-cloudwatch-agent 2.5 MB +0 B +0 B
workload-discovery 3.0 MB +0 B +0 B
Total 206.4 MB +0 B ${\color{red}▲}$ +1.5 MB (+0.7%)
linux/amd64 amazon-cloudwatch-agent (last 9 main commits + this PR)

 195 ┤                                        
     ┤                        ███ ███ ███ ███ 
     ┤            ███ ███ ███ ███ ███ ███ ███ 
     ┤    ▄▄▄ ▄▄▄ ███ ███ ███ ███ ███ ███ ███ 
     ┤    ███ ███ ███ ███ ███ ███ ███ ███ ███ 
     ┤    ███ ███ ███ ███ ███ ███ ███ ███ ███ 
     ┤    ███ ███ ███ ███ ███ ███ ███ ███ ███ 
     ┤    ███ ███ ███ ███ ███ ███ ███ ███ ███ 
 195 ┤▄▄▄ ███ ███ ███ ███ ███ ███ ███ ███ ███ 
 MB  └────────────────────────────────────────
      4235e66                             PR
linux/arm64
Binary PR vs main (0b21e7a) vs v1.300072.0
amazon-cloudwatch-agent 178.6 MB +0 B ${\color{red}▲}$ +1.5 MB (+0.9%)
amazon-cloudwatch-agent-config-wizard 2.0 MB +0 B +0 B
config-downloader 2.0 MB +0 B +0 B
config-translator 2.0 MB +0 B +0 B
start-amazon-cloudwatch-agent 2.4 MB +0 B +0 B
workload-discovery 2.9 MB +0 B +0 B
Total 189.9 MB +0 B ${\color{red}▲}$ +1.5 MB (+0.8%)
windows/amd64
Binary PR vs main (0b21e7a) vs v1.300072.0
amazon-cloudwatch-agent.exe 197.6 MB ${\color{red}▲}$ +7.7 KB (+0.0%) ${\color{red}▲}$ +1.5 MB (+0.8%)
amazon-cloudwatch-agent-config-wizard.exe 2.1 MB +0 B +0 B
config-downloader.exe 2.1 MB +0 B +0 B
config-translator.exe 2.1 MB +0 B +0 B
start-amazon-cloudwatch-agent.exe 2.3 MB +0 B +0 B
workload-discovery.exe 2.9 MB +0 B ${\color{red}▲}$ +512 B (+0.0%)
Total 209.3 MB ${\color{red}▲}$ +7.7 KB (+0.0%) ${\color{red}▲}$ +1.5 MB (+0.7%)
Investigating size changes

Use go-size-analyzer to compare binaries:

GOEXPERIMENT=jsonv2 go install github.com/Zxilly/go-size-analyzer/cmd/gsa@latest
gsa diff --old <baseline-binary> --new <new-binary>

@jefchien jefchien added the ready for testing Indicates this PR is ready for integration tests to run label Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for testing Indicates this PR is ready for integration tests to run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant