Conversation
TingDaoK
changed the title
TingDaoK
changed the title
azkrishpy
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
S3FileIoOptionsclass docstring anddirect_iofield documentation were outdated — the class said "only applies whensend_filepathis set" and the field only mentioned upload.Updated documentation to reflect current behavior:
send_filepath(upload) andrecv_filepath(download)direct_iofield: documents non-Linux transparent fallback, upload hard-fail on unaligned part_size, download best-effort fallback conditionsHighlight: With this change, download 5TiB file to a RAID0 disk with 150Gbps throughput, we are able to reach 109 Gb/s with 400GiB memory usage. Meanwhile same configurations and resource usage without direct_io write can only reach 15 Gb/s due to kernel limitation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.