test(memory): live cross-conversation memory regression - #16
Merged
Conversation
Adds a gated (SAK_LIVE_TESTS=1) live test proving the shared-store memory contract against glm-5.2:cloud: a fact told to one agent is persisted via the remember tool (USER.md) and recalled by a *different* agent sharing the same FileAgentMemoryStore — the pattern Naseem uses so every conversation shares one memory. Passed 3/3 locally. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gated live test (
SAK_LIVE_TESTS=1) documenting and verifying the shared-store memory contract used by the Naseem app:remembertool persists it toUSER.md.FileAgentMemoryStore, no shared chat history — recalls the name.This is the mechanism that makes an agent remember you across conversations. Test-only change (no framework source change); the memory system already existed — this pins its cross-agent behavior.
Passed 3/3 locally against
glm-5.2:cloud(~2–5s). Gated, so CI stays hermetic. All 97 hermetic tests pass.🤖 Generated with Claude Code