Allow persistent media navigation across site pages#1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
X-Frame-Options: SAMEORIGINWhy
The site-wide media player keeps the player in the top document and loads site navigation in a same-origin frame. Spring Security's default
DENYheader blocked that frame, leaving the visible route on/sharedand showing a refused-to-connect page after clicking Messages.External sites remain unable to frame the application because
SAMEORIGINpermits only the exact same origin.Validation
:website:test --tests dev.christopherbell.sharedfolder.SharedFolderSecurityIntegrationTest:website:test :website:jsTest(all Java tests and 182 JavaScript tests passed)