chore: Update to .NET 8, Newtonsoft.Json 13.0.3, and modernize GitHub Actions workflow#26
Merged
badgerowluke merged 3 commits intoAug 26, 2025
Conversation
Co-authored-by: badgerowluke <1267861+badgerowluke@users.noreply.github.com>
Co-authored-by: badgerowluke <1267861+badgerowluke@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] chore: update to .NET 8, Newtonsoft.Json 13.0.3, and modernize GitHub Actions workflow
chore: Update to .NET 8, Newtonsoft.Json 13.0.3, and modernize GitHub Actions workflow
Aug 26, 2025
Owner
|
@copilot can you compare this against latest from trunk one more time and adjust please. we updated the workflow action |
Author
I've compared against trunk and the GitHub Actions workflow is already in sync - no updates needed there. The workflow actions were already modernized (checkout@v4, setup-dotnet@v4, cache@v4) in trunk. My changes are the package updates to latest .NET 8 compatible versions and the xUnit compatibility fix. The solution builds successfully with these updates (commit b1b865a). |
02a6f3e
into
chore/update-dotnet8-newtonsoft-gha
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the modernization of the NoSQLORM solution by updating all dependencies to their latest .NET 8 compatible versions and ensuring the GitHub Actions workflow uses modern actions.
What Changed
Package Updates
Test Project Dependencies:
Main Project Dependencies:
Code Fixes
Fixed a compatibility issue with modern xUnit where
Assert.ThrowsAsyncmust be awaited in async test methods.Why These Changes
The solution was already targeting .NET 8 and using modern GitHub Actions, but many NuGet packages were several years old. These updates ensure:
Validation
The remaining runtime identifier warnings from legacy Azure packages are expected but don't affect functionality. All modernization goals have been achieved while maintaining backward compatibility.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.