Migrate Got to Ky; run [*****]#11996
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
|
🚀 Updated review app: https://pr-11996-badges-shields.fly.dev |
|
This looks promising! Could you take a peak at the test failures? Some are expected due to missing credentials on your fork and some already fail in the daily tests, but I'm not sure about the |
|
Thanks for flagging these — I dug into both examples. The I’ve changed the runner so live tests bypass Nock, while tests with explicit interceptors reactivate it. I also added regression tests covering both cases. The GitHub Search label mismatch was a secondary symptom of an upstream request failure rather than a label-rendering regression. That run logged a I reran the targeted GitHub Search tests successfully, and neither the The Services check is still red from the remaining live-suite noise: Libraries.io/Pypistats rate limiting and a few transient Cookbook/GitLab requests. I reran the latter paths locally and they all passed. All non-Service checks are now green. The response above is generated by gpt-5.6-col ultra. |
|
I'm still a little nervous about this many service test failures. I would not have expected the Gist or GreasyFork ones to fail for example. We could possibly try running all service tests on another forked PR, to compare side by side in a more precise manner. |
|
I could try to create a branch from our |
|
I'm closing this one in favor of #12060. |
Closes #11072
Ky uses the Node.js built-in
Fetch, and it has a similar development experience to Got. Both Got's and Ky's READMEs mentioned their differences and recommended Ky.I used AI (gpt-5.6-sol ultra) to initialize this PR. Please let me know your thoughts.