fix(config): honor XDG_CONFIG_HOME on all platforms - #67
Merged
Conversation
On MacOS XDG_CONFIG_HOME is not checked and mdterm falls back on the platform default config directory. When figuring out config_path, check if XDG_CONFIG_HOME is set explicitly on all platforms. Fixes: bahdotsh#66
Contributor
Author
|
@bahdotsh friendly ping |
ferdinandyb
force-pushed
the
fix/xdg-config-home
branch
2 times, most recently
from
July 30, 2026 12:24
c0afdb5 to
d65217c
Compare
Contributor
Author
|
@bahdotsh rebased on origin/HEAD, should make the clippy error go away |
Owner
|
Hey @ferdinandyb thank you so much for the PR and for your patience! Everything looks good! Can merge after clippy fixes! |
bahdotsh
approved these changes
Aug 1, 2026
Contributor
Author
|
On Sat Aug 01, 2026 at 16:24, Gokul ***@***.***> wrote:
bahdotsh left a comment (bahdotsh/mdterm#67)
Hey @ferdinandyb thank you so much for the PR and for your patience!
Everything looks good! Can merge after clippy fixes!
hey, thanks for taking a look!
I'm a bit confused though, my patch only touches `src/config.rs` while clippy
is complaining about `src/viewer.rs:2642:69`. Hmm and indeed I can repro the
clippy error on main as well. I would think this should be fixed with
a separate patch first and then mine? Do you want me to do that in this PR?
…--
bence.ferdinandy.com
|
Owner
|
Ooh interesting. I have an open PR, will get this sorted there then. Thank you for you contribution! |
Contributor
Author
|
On Mon Aug 03, 2026 at 05:06, Gokul ***@***.***> wrote:
bahdotsh left a comment (bahdotsh/mdterm#67)
Ooh interesting. I have an open PR, will get this sorted there then. Thank you for you contribution!
awesome, thanks!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MacOS XDG_CONFIG_HOME is not checked and mdterm falls back on the platform default config directory. When figuring out config_path, check if XDG_CONFIG_HOME is set explicitly on all platforms.
Fixes: #66