docs(base44-troubleshooter): name both causes of the polling fallback - #158
Merged
Conversation
The raw-SSE aside said the CLI falls back to polling when the first connection is "refused", which is one of two causes. A first connect that keeps failing transiently exhausts its retries and polls too. The two-modes section above it already documents both, so the aside contradicted its own page. Caught in review of #157 after it merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line follow-up to #157, from
cli-logs-realtime's post-merge review.The aside in Driving the SSE endpoint directly said the CLI's polling fallback is "driven by the first connection being refused". That is one of two causes — a first connect that keeps failing transiently also exhausts its retries and polls (
connectWhileTransientlyUnavailable→opened.kind !== "stream"→ warn +pollLogs).The Streaming or polling is decided once, at startup section on the same page already documents both cases correctly, so the aside contradicted its own page. No reader was likely to be misled, but it was wrong in
main.Verified against cli
mainat50ad740,packages/cli/src/cli/commands/project/logs.ts:256-266.