fix(account): Google OAuth originating domain + remove legacy Career fields - #1062
Merged
Conversation
AldemirLucas
approved these changes
Aug 19, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subset of #1057, cut fresh from
mainas requested — Google login fixes and the migration only.No Stripe or pricing changes.
What's here
fix(account): return Google OAuth to the originating frontend domain.Adds a per-environment allowlist of the three sibling frontends (pt → basedosdados.org,
en → data-basis.org, es → basedelosdatos.org) and honours a
redirect_originsent by the loginpage. The allowlist is what makes this safe: a JWT rides in the redirect URL, so an unvalidated
origin would be an open redirect that leaks tokens. Backward compatible — when
redirect_originis absent or not allowlisted, it falls back tosettings.FRONTEND_URL, i.e.exactly today's behaviour.
refactor(account): remove legacyCareer.team_old/role_old, with migrationaccount/0029_remove_career_team_old_remove_career_role_old.Deliberately excluded
#1044(expose Stripe price id) and#1045(card-country regional price at checkout) stay on#1057. There is zero file overlap between the two groups — this branch touches no
account_payment/file — so the split is clean and the two can land independently.Review notes
0028_alter_account_uuidis already onmain, so the chain is intact. Verified that the website frontend references neitherteam_old/role_oldnorteamOld/roleOld, so this is invisible to the frontend.mainwith no conflicts; original authorship preserved and(cherry picked from …)provenance recorded on each.