Skip to content

fix(account): Google OAuth originating domain + remove legacy Career fields - #1062

Merged
rdahis merged 2 commits into
mainfrom
fix/google-login-and-migrations
Aug 19, 2026
Merged

fix(account): Google OAuth originating domain + remove legacy Career fields#1062
rdahis merged 2 commits into
mainfrom
fix/google-login-and-migrations

Conversation

@rdahis

@rdahis rdahis commented Aug 19, 2026

Copy link
Copy Markdown
Member

Subset of #1057, cut fresh from main as requested — Google login fixes and the migration only.
No Stripe or pricing changes.

What's here

  • fix(account): return Google OAuth to the originating frontend domain #1046 fix(account): return Google OAuth to the originating frontend domain.
    Adds a per-environment allowlist of the three sibling frontends (pt → basedosdados.org,
    en → data-basis.org, es → basedelosdatos.org) and honours a redirect_origin sent by the login
    page. The allowlist is what makes this safe: a JWT rides in the redirect URL, so an unvalidated
    origin would be an open redirect that leaks tokens. Backward compatible — when
    redirect_origin is absent or not allowlisted, it falls back to settings.FRONTEND_URL, i.e.
    exactly today's behaviour.
  • refactor(account): remove legacy Career.team_old and role_old fields #1048 refactor(account): remove legacy Career.team_old / role_old, with migration
    account/0029_remove_career_team_old_remove_career_role_old.

Deliberately excluded

#1044 (expose Stripe price id) and #1045 (card-country regional price at checkout) stay on
#1057. There is zero file overlap between the two groups — this branch touches no
account_payment/ file — so the split is clean and the two can land independently.

Review notes

  • The migration drops two columns. Its dependency 0028_alter_account_uuid is already on
    main, so the chain is intact. Verified that the website frontend references neither
    team_old/role_old nor teamOld/roleOld, so this is invisible to the frontend.
  • Both commits cherry-picked onto main with no conflicts; original authorship preserved and
    (cherry picked from …) provenance recorded on each.

@rdahis
rdahis requested a review from AldemirLucas August 19, 2026 22:57
@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@rdahis
rdahis merged commit 9dd445c into main Aug 19, 2026
4 of 5 checks passed
@Winzen Winzen added the prod Indica que o Pull Request está com a branch de destino (base) apontando para main label Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prod Indica que o Pull Request está com a branch de destino (base) apontando para main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants