⬆️ Update sindresorhus/KeyboardShortcuts to v3#594
Conversation
Greptile SummaryThis PR bumps the
Confidence Score: 4/5Do not merge without updating the three The package manifest and lock file are correctly updated, but the v3.0.0 breaking rename of the macos/AgentCLI/Sources/AgentCLI/Shortcuts.swift — three KeyboardShortcuts.Name initializer call sites still use the removed Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Package.swift\npins KeyboardShortcuts 3.0.1] --> B[Package.resolved\nupdated revision]
B --> C{Build Shortcuts.swift}
C -->|default: label removed in v3| D["❌ Compile Error\n3× KeyboardShortcuts.Name(_, default:)"]
C -->|after rename to initial:| E["✅ Build succeeds"]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Package.swift\npins KeyboardShortcuts 3.0.1] --> B[Package.resolved\nupdated revision]
B --> C{Build Shortcuts.swift}
C -->|default: label removed in v3| D["❌ Compile Error\n3× KeyboardShortcuts.Name(_, default:)"]
C -->|after rename to initial:| E["✅ Build succeeds"]
Reviews (4): Last reviewed commit: "⬆️ Update sindresorhus/KeyboardShortcuts..." | Re-trigger Greptile |
b579975 to
4231cd8
Compare
4231cd8 to
9711830
Compare
This PR contains the following updates:
1.10.0→3.0.1Release Notes
sindresorhus/KeyboardShortcuts (sindresorhus/KeyboardShortcuts)
v3.0.1Compare Source
v3.0.0Compare Source
Breaking
Name#defaultShortcuttoName#initialShortcutNamedefault:parameter toinitial:Improvements
RecorderRecorderrepeatingKeyDownEvents(for:))KeyboardShortcuts.events(for:))KeyboardShortcuts.storedNamesgetterShortcut#toSwiftUIShortcut#isTakenBySystemFixes
NSMenuItem#setShortcut(for:)overriding a hardcoded key equivalent when no global shortcut is setv2.4.0Compare Source
NSEvent.ModifierFlags#ks_symbolicRepresentationisEnabled()method (#215)removeHandler()method (#216)RecorderCocoazero-size issue when added without constraintsv2.3.0Compare Source
Shortcut#nsMenuItemKeyEquivalentproperty045cf172d6b49ev2.2.4Compare Source
v2.2.3Compare Source
.globalKeyboardShortcut()323d9f8v2.2.2Compare Source
v2.2.1Compare Source
optionis present on macOS 15zhlocalizationsv2.2.0Compare Source
.resetAll()methodv2.1.0Compare Source
SwiftUI.View#globalKeyboardShortcut()methodOptionkey withoutCommandorControlon macOS 15 or later in sandboxed appsv2.0.2Compare Source
v2.0.1Compare Source
v2.0.0Compare Source
Breaking
04b8db6KeyboardShortcuts.on()method09e4a10NSMenuItem#setShortcut()method is now marked with@MainActor3b11952Improvements
3b11952v1.17.0Compare Source
LocalizedStringKeyinitializer toRecorderto support localizing the titlev1.16.1Compare Source
NSMenuItem#setShortcutv1.16.0Compare Source
de40257v1.15.0Compare Source
pt-BRlocalizationv1.14.1Compare Source
b878f81b878f81v1.14.0Compare Source
Spaceto indicate the space key instead of⎵.⌘⎵was confusing to users and macOS itself uses⌘Spacein their keyboard shortcut recorders and in menu items.v1.13.0Compare Source
v1.12.0Compare Source
NSMenu'sf0d470dKeyboardShortcuts.isMenuOpen, and the property has been made private.f0d470dv1.11.0Compare Source
018e445746f74eRecorderCocoa921c77eNote: The tag is now without a
vprefix since Xcode cannot handle the prefix.Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.