Skip to content

Silence protobuf sun.misc.Unsafe warnings from the direct header comp… #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davido wants to merge 1 commit into
base: master
Choose a base branch
from
+142 −0
Open

Silence protobuf sun.misc.Unsafe warnings from the direct header comp… #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions java/common/rules/java_toolchain.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,23 @@ def _java_toolchain_impl(ctx):
else:
header_compiler_direct_data = []
header_compiler_direct_jvm_opts = []

# protocolbuffers/protobuf#20760: Turbine's bundled protobuf (UnsafeUtil)
# calls terminally-deprecated sun.misc.Unsafe methods, which the JVM warns
# about on JDK 24+ (JEP 498). The Java TurbineDirect launcher does
# not receive turbine_jvm_opts, so those warnings cannot otherwise be
# silenced for the direct header compiler. Do not pass this JVM-only
# flag to turbine_direct_graal: its native binary parses these values
# as Turbine command-line options.
if (
java_runtime and
java_runtime.version >= 24 and
_is_java_launcher_tool(ctx.attr.header_compiler_direct)
):
header_compiler_direct_jvm_opts = header_compiler_direct_jvm_opts + [
"--sun-misc-unsafe-memory-access=allow",
]

if ctx.attr.oneversion_allowlist and ctx.attr.oneversion_whitelist:
fail("oneversion_allowlist and oneversion_whitelist are mutually exclusive")
oneversion_allowlist = ctx.file.oneversion_allowlist if ctx.file.oneversion_allowlist else ctx.file.oneversion_whitelist
Expand Down Expand Up @@ -156,6 +173,17 @@ def _get_java_runtime(ctx):
return None
return ctx.attr.java_runtime[ToolchainInfo].java_runtime

def _is_java_launcher_tool(tool):
"""Returns whether tool is packaged as a deploy jar run by java -jar.

Native tools such as turbine_direct_graal receive these values as tool
command-line options, not JVM options.
"""
if not tool:
return False
executable = tool[DefaultInfo].files_to_run.executable
return executable and executable.extension == "jar"

def _get_javac_opts(ctx):
opts = []
if ctx.attr.source_version:
Expand Down
114 changes: 114 additions & 0 deletions test/java/toolchains/java_toolchain_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ load("//java:java_binary.bzl", "java_binary")
load("//java:java_library.bzl", "java_library")
load("//java:java_plugin.bzl", "java_plugin")
load("//java/common:java_common.bzl", "java_common")
load("//java/toolchains:java_runtime.bzl", "java_runtime")
load("//test/java/testutil:java_info_subject.bzl", "java_info_subject")
load("//test/java/testutil:java_toolchain_info_subject.bzl", "java_toolchain_info_subject")
load("//test/java/testutil:javac_action_subject.bzl", "javac_action_subject")
Expand Down Expand Up @@ -560,6 +561,116 @@ def _test_java_compile_action_uses_tool_specific_jvm_opts_impl(env, target):
header_action = env.expect.that_target(target).action_generating("{package}/lib{name}-hjar.jar")
header_action.argv().contains("-DturbineFlag=1")

_UNSAFE_MEMORY_ACCESS_OPT = "--sun-misc-unsafe-memory-access=allow"

def _test_jdk24_unsafe_opt_for_java_direct_header_compiler(name):
util.helper_target(
java_runtime,
name = name + "/jdk24",
version = 24,
)
util.helper_target(
mock_java_toolchain,
name = name + "/java_toolchain",
header_compiler_direct = name + "/turbine_direct.jar",
java_runtime = name + "/jdk24",
)
util.helper_target(
java_library,
name = name + "/java_lib",
srcs = ["a.java"],
)

analysis_test(
name = name,
impl = _test_jdk24_unsafe_opt_for_java_direct_header_compiler_impl,
target = name + "/java_lib",
config_settings = {
"//command_line_option:java_header_compilation": "true",
"//command_line_option:extra_toolchains": [Label(name + "/java_toolchain")],
},
)

def _test_jdk24_unsafe_opt_for_java_direct_header_compiler_impl(env, target):
header_action = env.expect.that_target(target).action_generating(
"{package}/lib{name}-hjar.jar",
)

header_action.argv().contains("{package}/{test_name}/turbine_direct.jar")
header_action.argv().contains(_UNSAFE_MEMORY_ACCESS_OPT)

def _test_no_jdk23_unsafe_opt_for_java_direct_header_compiler(name):
util.helper_target(
java_runtime,
name = name + "/jdk23",
version = 23,
)
util.helper_target(
mock_java_toolchain,
name = name + "/toolchain",
header_compiler_direct = name + "/turbine_direct.jar",
java_runtime = name + "/jdk23",
)
util.helper_target(
java_library,
name = name + "/lib",
srcs = ["a.java"],
)

analysis_test(
name = name,
impl = _test_no_jdk23_unsafe_opt_for_java_direct_header_compiler_impl,
target = name + "/lib",
config_settings = {
"//command_line_option:java_header_compilation": "true",
"//command_line_option:extra_toolchains": [Label(name + "/toolchain")],
},
)

def _test_no_jdk23_unsafe_opt_for_java_direct_header_compiler_impl(env, target):
header_action = env.expect.that_target(target).action_generating(
"{package}/lib{name}-hjar.jar",
)

header_action.argv().contains("{package}/{test_name}/turbine_direct.jar")
header_action.argv().not_contains(_UNSAFE_MEMORY_ACCESS_OPT)

def _test_no_jdk24_unsafe_opt_for_native_direct_header_compiler(name):
util.helper_target(
java_runtime,
name = name + "/jdk24",
version = 24,
)
util.helper_target(
mock_java_toolchain,
name = name + "/native_toolchain",
header_compiler_direct = name + "/turbine_direct_graal",
java_runtime = name + "/jdk24",
)
util.helper_target(
java_library,
name = name + "/native_lib",
srcs = ["b.java"],
)

analysis_test(
name = name,
impl = _test_no_jdk24_unsafe_opt_for_native_direct_header_compiler_impl,
target = name + "/native_lib",
config_settings = {
"//command_line_option:java_header_compilation": "true",
"//command_line_option:extra_toolchains": [Label(name + "/native_toolchain")],
},
)

def _test_no_jdk24_unsafe_opt_for_native_direct_header_compiler_impl(env, target):
header_action = env.expect.that_target(target).action_generating(
"{package}/lib{name}-hjar.jar",
)

header_action.argv().contains("{package}/{test_name}/turbine_direct_graal")
header_action.argv().not_contains(_UNSAFE_MEMORY_ACCESS_OPT)

def _test_javabuilder_location_expansion_with_multiple_artifacts(name):
util.helper_target(
native.filegroup,
Expand Down Expand Up @@ -766,6 +877,9 @@ def java_toolchain_tests(name):
_test_java_compile_action_target_gets_javacopts_from_toolchain,
_test_java_compile_action_exec_gets_javacopts_from_toolchain,
_test_java_compile_action_uses_tool_specific_jvm_opts,
_test_jdk24_unsafe_opt_for_java_direct_header_compiler,
_test_no_jdk23_unsafe_opt_for_java_direct_header_compiler,
_test_no_jdk24_unsafe_opt_for_native_direct_header_compiler,
_test_javabuilder_location_expansion_with_multiple_artifacts,
_test_java_common_without_toolchain_type_fails,
_test_java_toolchain_flag_default,
Expand Down