1860 app inappbrowsercheck not working with new telegram - #1934
Open
MrDirkelz wants to merge 2 commits into
Open
1860 app inappbrowsercheck not working with new telegram#1934MrDirkelz wants to merge 2 commits into
MrDirkelz wants to merge 2 commits into
Conversation
ivanslabbert
left a comment
ivanslabbert
left a comment
Contributor
There was a problem hiding this comment.
There is a npm package / github repo that detects in-app browsers, with Telegram support. Check if it has been updated to detect Telegram correctly (after Telegram removed the API that was previously used by the library to detect the Telegram in-app browser).
MrDirkelz
force-pushed
the
1860-app-inappbrowsercheck-not-working-with-new-telegram
branch
from
August 28, 2026 09:17
c067151 to
e844409
Compare
Sample 10% of external app entries to capture real user agent, referrer, and detection result — Telegram's in-app browser doesn't always self-identify (e.g. never on iOS), so isTelegramBrowser() can false-negative and this data helps close the gap.
MrDirkelz
force-pushed
the
1860-app-inappbrowsercheck-not-working-with-new-telegram
branch
from
August 28, 2026 11:21
ae0454c to
2ba0a68
Compare
johan-bell
requested changes
Sep 1, 2026
johan-bell
left a comment
johan-bell
left a comment
Collaborator
There was a problem hiding this comment.
The move to inapp-spy introduces a regression for installed users:
inAppBrowser.ts:41— inapp-spy's generic pattern(iPhone|iPod|iPad)(?!.*Safari/)matches iOS home-screen PWA user agents (they omitSafari/), so installed iOS users would get the "open in your browser" interstitial on every cold launch. Please gate on the existingisInstalledStandalone()fromapp/src/globalConfig.ts.inAppBrowser.ts:15— the comment saying inapp-spy has no Telegram detection isn't accurate: itsgetDetectClientSidealready checksTelegramWebviewProxy; only__tg__webview_setis genuinely additional.inAppBrowser.ts:27— the hand-rolled bridge check covers fewer properties (TelegramWebview,TelegramWebviewProxyProtomissing) than the library it supplements.- Test gap: an iOS standalone user-agent case in
playwright-tests/app/flows/in-app-browser.spec.tswould have caught the PWA regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.