fix(HomePageSearch): add missing bottom padding to search bar on mobile screen - #1966
Open
ChrisTouo wants to merge 3 commits into
Open
fix(HomePageSearch): add missing bottom padding to search bar on mobile screen#1966ChrisTouo wants to merge 3 commits into
ChrisTouo wants to merge 3 commits into
Conversation
Collaborator
Author
|
Contributor
|
There is already padding added by following horizontal scrollable carousels, so this will result in double padding. Instead of adding padding, set the background colour to:
|
johan-bell
approved these changes
Sep 1, 2026
johan-bell
left a comment
johan-bell
left a comment
Collaborator
There was a problem hiding this comment.
Nice — switching the accent band to be conditional on pinned categories (instead of padding) is the right call and fixes the flush band on mobile. One edge case to keep in mind: hasPinnedCategories is true whenever a pinned category doc exists, but HomePagePinned only renders categories that actually have content, so a pinned category with no visible content in the user's language would still paint the band with nothing following it. Fine to handle in a follow-up if it shows up in practice.
ivanslabbert
reviewed
Sep 1, 2026
…mitted event from HomePagePinned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.