chore(security): non-breaking npm audit fix for app, cms and shared - #1973
Open
MrDirkelz wants to merge 1 commit into
Open
chore(security): non-breaking npm audit fix for app, cms and shared#1973MrDirkelz wants to merge 1 commit into
MrDirkelz wants to merge 1 commit into
Conversation
Lockfile-only sweep — no package.json changes and no major upgrades. Clears app's shell-quote critical plus 20 highs that have accumulated since #1849 (lodash-es, postcss, rollup, glob, form-data, js-cookie, flatted, fast-uri, @xmldom/xmldom, editorconfig and the workbox/babel chain), and js-yaml, nanoid and brace-expansion across all three. api is deliberately excluded: #1950 rewrites its lockfile and already carries newer js-yaml than main. Refs #1868 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Alerts have re-accumulated since #1849. Not all of them need the breaking major upgrades tracked in #1868 — this clears everything
npm audit fixcan resolve without touching apackage.json, so the remaining migration slices start from a smaller, cleaner diff.What changed
Lockfiles only. No
package.jsonchanges, no major upgrades, no source changes.app loses the
shell-quotecritical and 20 highs —lodash-es,postcss,rollup,glob,form-data,js-cookie,flatted,fast-uri,@xmldom/xmldom,editorconfig, plus the workbox/babel chain. cms and shared pick upjs-yaml,nanoidandbrace-expansion.api is deliberately excluded. #1950 rewrites
api/package-lock.jsonwholesale and already carriesjs-yaml@4.3.1/@istanbuljs/…/js-yaml@3.15.1, both newer than main and both out of the advisory range. Including api here would buy nothing and put a conflict in front of an approved PR.Verification
vue-tsc+vite buildThe shared test failure is pre-existing
src/util/HybridQuery/responseCache.spec.ts→ "drops any stale entry for the key when the write overflows quota".Restoring the pre-sweep lockfile and running
npm cireproduces it identically, so it is not fallout from this change. Root cause:vi.spyOn(Storage.prototype, "setItem")does not interceptlocalStorage.setItemunder jsdom 24 — the spy never fires, the write succeeds, and the assertion sees the new entry instead ofundefined. Its sibling test (swallows a thrown setItem) passes vacuously for the same reason.writeResponseCachedoes callremoveItemin its catch, so this is a broken test rather than broken code. Tracked separately.Only three lockfile entries changed in shared (
brace-expansion,js-yaml,nanoid), none of them jsdom.What's left
All of it is devDependency tooling that never ships, and none of it is production-reachable. Continues in #1868:
The
@typescript-eslint/*high cluster (5 alerts × 3 packages) reports asfixAvailable: truebut cannot be moved here — it is pinned by@vue/eslint-config-typescript@12's peer range, so it belongs to the eslint slice.Refs #1868
🤖 Generated with Claude Code