Updated helm reference to new tusd_py3 docker image, the image contai…#405
Open
TimOsse wants to merge 3 commits into
Open
Updated helm reference to new tusd_py3 docker image, the image contai…#405TimOsse wants to merge 3 commits into
TimOsse wants to merge 3 commits into
Conversation
…ns the latest version of tusd with bug fixes
adodge-bcg
reviewed
Jan 25, 2023
|
|
||
| tus: | ||
| image: h3brandon/tusd_py3 | ||
| image: tosse/tusd_py3 |
There was a problem hiding this comment.
Is this the helm chart that is used in the deploy?
From what I remember, most of brandons helm charts got moved to https://github.com/bcgov/helm-charts
There was a problem hiding this comment.
Author
There was a problem hiding this comment.
I see what you mean, I am not sure which one is being used. I have no documentation on the deployment.
Author
There was a problem hiding this comment.
This storage-api microservice has not been modified in 3 years while the helm-charts version was last modified 2 years ago. So have made the same change to the helm-chart version, and i will have a PR for review momentarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated helm reference to new tusd_py3 docker image, the image contains the latest version of tusd with bug fixes