34460 error downloading - #4713
Open
benjamin-bc-gov wants to merge 5 commits into
Open
Conversation
kialj876
reviewed
Aug 20, 2026
kialj876
left a comment
kialj876
left a comment
Collaborator
There was a problem hiding this comment.
Couple comments for you below
Collaborator
There was a problem hiding this comment.
'token' is unused now I think? Please remove it if so
| assert rv_data == expected | ||
|
|
||
|
|
||
| def test_receipt_download_uses_service_token(session, client, jwt, mocker): |
Collaborator
There was a problem hiding this comment.
I don't think we need another test here, you can just validate the token used in the 'test_get_receipt' and 'test_get_receipt_request_mock' test
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#34460
Description of changes:
updated how pay API is called in receipt download