excellent changes#2
Open
bd-swright wants to merge 2 commits intomasterfrom
Open
Conversation
embiggen the impact level
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| public static int badidea() { | ||
| int a = 1; | ||
| int b = 0; | ||
| int c = a/b; |
There was a problem hiding this comment.
Auto-generated PR comment (Coverity)
Coverity Issue - Division or modulo by zero
Priority: Medium
Vulnerability: CWE-369
CID: 10019
In expression "a / b", division by expression "b" which may be zero results in an exception.
The program will raise an exception.
| int b = 0; | ||
| int c = a/b; | ||
|
|
||
| for (int i=0; i<a; i--) { |
There was a problem hiding this comment.
Auto-generated PR comment (Coverity)
Coverity Issue - Infinite loop
Priority: Medium
Vulnerability: CWE-835
CID: 10020
Top of the loop.
The loop does not have a normal termination condition, so will continue until an abnormal condition arises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no need to review, this is great