chore(repo): pin Node at the root, and drop a Sponsor button that leads nowhere - #637
Merged
Merged
Conversation
…ds nowhere Closes #565, closes #563. **#565 — nothing enforced the Node version.** CI runs Node 20 and CONTRIBUTING said to pin it locally, but there was no `.nvmrc` and no root `engines`, so a contributor on 18 or 24 found out from a failing job. - `.nvmrc` with `20`, read by nvm, fnm, asdf and volta alike - root `engines: { "node": ">=20 <21" }`, the range the workflows actually use - `.nvmrc` added to the root-cleanliness allowlist, which is where the repository decides what may sit at the root -- the guard rejected it first, exactly as the issue said it would - the taxonomy's root policy updated in both languages to say the same, and three stale claims in that same section corrected while there: it still listed `DOCUMENTATION_VERSIONS.md` (no such file), `rulesets/` at the root (it moved under `src/`), and asserted "no application `src/` directories are maintained in this repository" -- which is now the opposite of true It warns, it does not block: `engine-strict` is off, verified against this machine's Node 24 -- `npm install` emits `EBADENGINE` and exits 0. The published CLI keeps `engines.node >= 18.0.0`, because that is a statement about consumers, not about building this repository. **#563 — the Sponsor button offered nothing.** The issue reported four empty keys; two of them did have values, so the file was checked rather than trusted: - `beyondnetcode` has no GitHub Sponsors listing (`hasSponsorsListing: false`), so `github: [beyondnetcode]` rendered a button leading to a page that does not exist - `sponsor:` is not a key GitHub's FUNDING.yml schema defines at all - `patreon:` and `open_collective:` are empty Nothing in the file was real, so the file is gone -- which is what the issue proposed for that case. Verified: root-cleanliness passes with `.nvmrc` present (46 entries read, 43 checked), guards 01 and 04 green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: aarroyo <beyondnet.peru@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
… not lost `08-validate-tracking.mjs` caught the deletion immediately: GT-555 closed on six evidence artifacts and one of them was `.github/FUNDING.yml`, which #563 removed. The guard is right to refuse -- a closed gap pointing at a file that no longer exists is a closure nobody can re-check. Rather than repoint or quietly drop it: - the artifact leaves GT-555's evidence list, and the record says in its own words WHY, so the removal does not read as an omission - the acceptance criterion in both catalog halves is KEPT and annotated as superseded, because it was satisfied when it was written. Rendering was never the problem; what it rendered was. The other five artifacts are untouched and still carry the closure. Verified: `08-validate-tracking.mjs` passes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: aarroyo <beyondnet.peru@gmail.com>
Contributor
Author
|
GT-555 closed on six evidence artifacts and one of them was Fixed in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #565, closes #563.
#565 — nothing enforced the Node version
CI runs Node 20 and CONTRIBUTING said to pin it locally, but there was no
.nvmrcand no rootengines, so a contributor on 18 or 24 found out from a failing job..nvmrcwith20— read by nvm, fnm, asdf and volta alikeengines: { "node": ">=20 <21" }, the range the workflows actually use.nvmrcadded to the root-cleanliness allowlist. The guard rejected it first, exactly as the issue said it wouldIt warns, it does not block.
engine-strictis off, verified on this machine's Node 24:npm installemitsEBADENGINEand exits 0. The published CLI keepsengines.node >= 18.0.0— that is a statement about consumers, not about building this repository, and CONTRIBUTING now says so in both languages.Three stale claims corrected in the same taxonomy section, since the change had to edit it anyway: it still listed
DOCUMENTATION_VERSIONS.md(no such file),rulesets/at the repository root (it moved undersrc/months ago), and asserted "No applicationsrc/directories are maintained in this repository" — now the opposite of true.#563 — the Sponsor button offered nothing
The issue reported four keys with no value. Two of them did have values, so the file was checked rather than trusted:
github: [beyondnetcode]hasSponsorsListing: false— the button led to a page that does not existsponsor: [beyondnetcode]patreon:open_collective:Nothing in the file was real, so the file is gone — which is what the issue proposed for that case.
Verification
03-validate-root-cleanliness.mjspasses with.nvmrcpresent: 46 root entries read, 3 ignored by git, 43 checked against the taxonomy🤖 Generated with Claude Code