Normalize cloned grad_absmax metrics for structured progress payloads - #2913
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Normalize cloned Jul 27, 2026
grad_absmax metrics for structured progress payloads
bghira
marked this pull request as ready for review
July 27, 2026 03:37
…ot/fix-code-review-comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structured progress/webhook metrics were inconsistent between grad clipping modes: the
"norm"path serialized cloned values to floats, while the"value"path could emit a Tensor forgrad_absmax. This updates the value-clipping path to normalize cloned metrics the same way.Metric serialization
Trainer._update_grad_metrics()soclone_norm_value=Trueconvertsgrad_absmaxto a detachedfloatin the"value"clipping path.Focused coverage
grad_absmaxserialization in the value-clipping path.Behavioral example