Unify method/action resolution and improve hx-action doco#3883
Open
MichaelWest22 wants to merge 2 commits into
Open
Unify method/action resolution and improve hx-action doco#3883MichaelWest22 wants to merge 2 commits into
MichaelWest22 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Found we can improve hx-action to fall back to formmethod and method native attributes just like hx-boost already does. This allows some better progressive enhancement options when moving to use the more natural action based attribute. You can place a hx-action on a form and have it use native method attributes.
By combining hx-action and hx-boost action and method calculation logic it also simplifies the code required as well.
Updated doco to highlight the progressive enhancment options and method fallback.
Corresponding issue:
Testing
Added new hx-action tests to cover the new behavior. should be no problem breaking changes for valid existing use cases as we are just adding a method fallback that was not usable before and it would have been confusing before if native method did not override the method used.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded