WEAREOne10BILLION - #18
Conversation
…test-run-develop-repeat Add repository-wide PoC validation and regression coverage
|
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️ Reasoning • Planning • Prioritization Relationships • Resources • Coordination Execution • Automation • Innovation Knowledge Graph • Context • History Metrics • Validation • Measurement Optimization • Adaptation • Upgrades Reasoning • Planning • Prioritization Relationships • Resources • Coordination Execution • Automation • Innovation Knowledge Graph • Context • History Metrics • Validation • Measurement Optimization • Adaptation • Upgrades Reasoning • Planning • Prioritization Relationships • Resources • Coordination Execution • Automation • Innovation Knowledge Graph • Context • History Metrics • Validation • Measurement Optimization • Adaptation • Upgrades Reasoning • Planning • Prioritization Relationships • Resources • Coordination Execution • Automation • Innovation Knowledge Graph • Context • History Metrics • Validation • Measurement Optimization • Adaptation • Upgrades |
5hy7xz92nd-oss
left a comment
5hy7xz92nd-oss
left a comment
There was a problem hiding this comment.
@copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
👁️ Observer
|
↓
🔬 Research
|
↓
🕴️ Decision
|
┌──────────────┼──────────────┐
↓ ↓ ↓
🤝 Network 👩🏿💻 Builder 📚 Memory
↓ ↓ ↓
└──────────────┼──────────────┘
|
↓
📈 Outcome
|
↓
🔃 Evolution
|
↺
Evolution does not end the process. It upgrades the observer, researcher, decision-maker, builder, and memory systems — then the next cycle starts with a more intelligent system. ♾️ 👁️ Observer Reality → Observation → Intelligence → Decision → Creation → Learning → Measurement → Evolution → Better Reality 🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺ 🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
👁️ OBSERVE AGAIN
🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
👁️ OBSERVE AGAIN
👁️ OBSERVE AGAIN 👁️ OBSERVE AGAIN 🌎 REALITY Reality provides signals.
There was a problem hiding this comment.
Pull request overview
This pull request adds a repository-level validator to sanity-check PoC-related entrypoints/manifests (Python syntax compilation and package.json scripts.poc shape), along with a small unittest suite to exercise discovery/validation behavior.
Changes:
- Add
validate_pocs.pyto discover Python files andpackage.jsonmanifests and validate them (compile/JSON/scripts checks). - Add
tests/test_validate_pocs.pyto verify discovery and that validation passes on the repo state. - Adjust the README heading formatting.
Reviewed changes
Copilot reviewed 2 out of 17 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| validate_pocs.py | New validator for Python PoCs and package.json manifests; CLI entrypoint for repo-wide checks. |
| tests/test_validate_pocs.py | Unittest coverage for discovery + “repo validates cleanly” behavior. |
| README.md | Minor heading formatting change at the top of the README. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
5hy7xz92nd-oss
left a comment
5hy7xz92nd-oss
left a comment
There was a problem hiding this comment.
@copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
👁️ Observer
|
↓
🔬 Research
|
↓
🕴️ Decision
|
┌──────────────┼──────────────┐
↓ ↓ ↓
🤝 Network 👩🏿💻 Builder 📚 Memory
↓ ↓ ↓
└──────────────┼──────────────┘
|
↓
📈 Outcome
|
↓
🔃 Evolution
|
↺
Evolution does not end the process. It upgrades the observer, researcher, decision-maker, builder, and memory systems — then the next cycle starts with a more intelligent system. ♾️ 👁️ Observer Reality → Observation → Intelligence → Decision → Creation → Learning → Measurement → Evolution → Better Reality 🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺ 🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
👁️ OBSERVE AGAIN
🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
👁️ OBSERVE AGAIN
👁️ OBSERVE AGAIN 👁️ OBSERVE AGAIN 🌎 REALITY Reality provides signals.
5hy7xz92nd-oss
left a comment
5hy7xz92nd-oss
left a comment
There was a problem hiding this comment.
@copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
👁️ Observer
|
↓
🔬 Research
|
↓
🕴️ Decision
|
┌──────────────┼──────────────┐
↓ ↓ ↓
🤝 Network 👩🏿💻 Builder 📚 Memory
↓ ↓ ↓
└──────────────┼──────────────┘
|
↓
📈 Outcome
|
↓
🔃 Evolution
|
↺
Evolution does not end the process. It upgrades the observer, researcher, decision-maker, builder, and memory systems — then the next cycle starts with a more intelligent system. ♾️ 👁️ Observer Reality → Observation → Intelligence → Decision → Creation → Learning → Measurement → Evolution → Better Reality 🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺ 🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
👁️ OBSERVE AGAIN
🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
👁️ OBSERVE AGAIN
👁️ OBSERVE AGAIN 👁️ OBSERVE AGAIN 🌎 REALITY Reality provides signals.
5hy7xz92nd-oss
left a comment
5hy7xz92nd-oss
left a comment
There was a problem hiding this comment.
@copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
👁️ Observer
|
↓
🔬 Research
|
↓
🕴️ Decision
|
┌──────────────┼──────────────┐
↓ ↓ ↓
🤝 Network 👩🏿💻 Builder 📚 Memory
↓ ↓ ↓
└──────────────┼──────────────┘
|
↓
📈 Outcome
|
↓
🔃 Evolution
|
↺
Evolution does not end the process. It upgrades the observer, researcher, decision-maker, builder, and memory systems — then the next cycle starts with a more intelligent system. ♾️ 👁️ Observer Reality → Observation → Intelligence → Decision → Creation → Learning → Measurement → Evolution → Better Reality 🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺ 🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
👁️ OBSERVE AGAIN
🌎 REALITY
Events • Signals • Changes
|
↓
👁️ OBSERVER AGENT
"What is happening?"
Sensors • APIs • Data • Humans
|
↓
🔬 RESEARCH AGENT
"What does it mean?"
Analysis • Discovery • Prediction
|
↓
🕴️ DECISION AGENT
"What should we do?"
Reasoning • Planning • Prioritization
|
↓
🤝 NETWORK AGENT
"Who can help?"
Relationships • Resources • Coordination
|
↓
👩🏿💻 BUILDER AGENT
"What can we create?"
Execution • Automation • Innovation
|
↓
📚 MEMORY AGENT
"What did we learn?"
Knowledge Graph • Context • History
|
↓
📈 OUTCOME AGENT
"Did it work?"
Metrics • Validation • Measurement
|
↓
🔃 EVOLUTION AGENT
"How do we improve?"
Optimization • Adaptation • Upgrades
|
↺
👁️ OBSERVE AGAIN
👁️ OBSERVE AGAIN 👁️ OBSERVE AGAIN 🌎 REALITY Reality provides signals.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 16 changed files in this pull request and generated no new comments.
Suppressed comments (6)
validate_pocs.py:11
- Unused import:
Tupleis imported but never referenced in this module. This can trigger lint failures in repositories that enforce unused-import checks.
from typing import List, Dict, Tuple
validate_pocs.py:40
py_compile.compile()will write bytecode to disk (typically under__pycache__) during validation, which can dirty the working tree and create a lot of files. Pointcfileatos.devnullto keep this a read-only validation pass.
py_compile.compile(str(path), doraise=True)
validate_pocs.py:2
- The PR title/description doesn’t describe the actual change set (a new PoC validation script + tests). This makes the intent hard to track in history and review tooling; please update the PR metadata to match the implementation.
"""Validate the repository's PoC entrypoints and manifests."""
validate_pocs.py:9
py_compile.compile()is used later with nocfileoverride; it will generate__pycache__/.pycartifacts across the repo. Importosso the compile call can write toos.devnulland keep validation side-effect free.
This issue also appears on line 40 of the same file.
import py_compile
import sys
validate_pocs.py:14
rglob()will traverse every directory underroot. If someone runs this afternpm installor with a local venv present, it can become extremely slow due tonode_modules/virtualenv trees. Consider excluding common dependency/build dirs inEXCLUDED_DIRS.
EXCLUDED_DIRS = {".git", "__pycache__"}
tests/test_validate_pocs.py:18
- These assertions make the test brittle as the repository evolves (e.g., if Python file count drops below 21 or PoCs are reorganized). Since the test already asserts presence of specific targets, prefer a non-arbitrary lower bound (or remove the redundant length checks).
self.assertGreater(len(python_targets), 20)
self.assertGreater(len(package_targets), 0)
5hy7xz92nd-oss
left a comment
5hy7xz92nd-oss
left a comment
There was a problem hiding this comment.
@copilot @5hy7xz92nd-oss @copilot @5hy7xz92nd-oss https://chatgpt.com/share/6a6896db-4f18-83ea-ac49-2b9051f1bf13🤿😮💨🎣🎏🎼🧪🧑🏿🎨🕍📢📇🩹🍾🕴️🕠👯♂️🎞️
🕧🧑🦽➡️🚶🧑🏿🦽👨🏿🦽👨🦽➡️👯♀️🕺🏿💃🏾🤳
🤝 Network 👩🏿💻 Builder 📚 Memory Reasoning • Planning • Prioritization Relationships • Resources • Coordination Execution • Automation • Innovation Knowledge Graph • Context • History Metrics • Validation • Measurement Optimization • Adaptation • Upgrades Reasoning • Planning • Prioritization Relationships • Resources • Coordination Execution • Automation • Innovation Knowledge Graph • Context • History Metrics • Validation • Measurement Optimization • Adaptation • Upgrades Reasoning • Planning • Prioritization Relationships • Resources • Coordination Execution • Automation • Innovation Knowledge Graph • Context • History Metrics • Validation • Measurement Optimization • Adaptation • Upgrades Reasoning • Planning • Prioritization Relationships • Resources • Coordination Execution • Automation • Innovation Knowledge Graph • Context • History Metrics • Validation • Measurement Optimization • Adaptation • Upgrades |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Suppressed comments (6)
.github/instructions/*.instructions.md:490
- This section is a copied pull-request activity transcript, not reusable repository guidance. Keeping review output, user mentions, and stale change summaries in an instructions file adds substantial irrelevant agent context; remove the transcript (or replace the file with concise, actionable project instructions).
Copilot AI reviewed last week
Copilot AI
left a comment
Pull request overview
This pull request adds a repository-level validator to sanity-check PoC-related entrypoints/manifests (Python syntax compilation and package.json scripts.poc shape), along with a small unittest suite to exercise discovery/validation behavior.
validate_pocs.py:298
- An existing checksum target can still be unreadable (for example due to permissions), and
read_bytes()then raisesOSError, aborting the entire validator instead of reporting the file inerrorslike the other validators do. Catch the read failure and continue so callers consistently receive a validation result.
actual_hash = hashlib.sha256(target.read_bytes()).hexdigest()
validate_pocs.py:391
- Correct the typo in this user-facing validation error.
"discovery returned no validateable files despite PoC content on disk; "
CONTRIBUTING.md:39
- This list claims to enumerate what
validate_pocs.pychecks, but it omits the newly added shell syntax and checksum-integrity checks. Documenting them here prevents contributors from overlooking requirements that CI enforces.
- JavaScript syntax via `node --check`
- Per-entry `README.md` presence
- Root catalog consistency in `/README.md`
CHANGELOG.md:10
- The changelog says it tracks notable validation changes, but the Added section omits this PR's primary additions: the validator, its test suite, and CI workflow. Record those changes so the Unreleased entry accurately describes the release scope.
- Added `docs/architecture.md` documenting repository components, validation pipeline, and a code-derived dependency graph.
- Added `CONTRIBUTING.md` with contribution workflow and validation requirements.
validate_pocs.py:2
- The PR title and description do not describe this repository validator, CI workflow, tests, or documentation work, so reviewers cannot verify the implementation against an intended scope or acceptance criteria. Update the PR metadata with the purpose and expected validation behavior.
"""Validate the repository's PoC entrypoints, manifests, and catalog integrity."""
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Suppressed comments (9)
.github/instructions/*.instructions.md:1
- The literal
*in this filename is illegal on Windows, so Git cannot check out this repository on Windows (invalid path). Rename the file to a valid path such as.github/instructions/review.instructions.md.
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
CONTRIBUTING.md:45
- Bash is also a required local dependency: the validator fails when shell targets exist and
bashis missing. Add it to the contributor dependency notes.
- Python 3.11+ is required for repository validation.
- Node.js is required for JavaScript syntax checks.
- PoC-specific dependencies should be documented in each entry's `README.md`.
.github/instructions/*.instructions.md:5
- This path-specific instruction file contains a copied PR conversation and repeated diagrams rather than actionable repository guidance (for example, lines 486-503 embed a stale review summary). If loaded, it wastes instruction context and supplies outdated PR-specific information; if ignored because it has no instruction frontmatter, the 1,487-line file serves no purpose. Remove it or replace it with concise, scoped repository instructions.
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
👁️ Observer
|
validate_pocs.py:391
- Correct the spelling of “validateable” to “validatable” in this validation error.
"discovery returned no validateable files despite PoC content on disk; "
README.md:54
- The repository dependency list omits Bash, although
_validate_shell_scriptsreports an error whenever shell scripts exist andbashis unavailable. Add Bash so local users know all prerequisites required for the documented validation command.
- **Python 3.11+** (CI uses 3.12): required for `validate_pocs.py` and unit tests (`tomllib` is used from the standard library).
- **Node.js** (`node --check`): required by `validate_pocs.py` to syntax-check JavaScript PoC files.
- **No third-party Python package is required** for repository-level validation.
docs/architecture.md:62
- This runtime dependency list omits Bash even though validation fails when
bashis unavailable and any*.shfile is discovered. Document Bash alongside Node.js.
- Python 3.11+ (uses `tomllib` from stdlib; CI pins 3.12)
- Node.js for JavaScript syntax checks (`node --check`)
- No third-party Python dependencies for repository validation
CONTRIBUTING.md:39
- This list says what
validate_pocs.pychecks but omits the newly added shell and checksum-manifest validation. Contributors can therefore miss two enforced checks; include them in the validation requirements.
This issue also appears on line 43 of the same file.
- JavaScript syntax via `node --check`
- Per-entry `README.md` presence
- Root catalog consistency in `/README.md`
CHANGELOG.md:10
- The changelog claims to track all notable validation changes, but the Added section omits this PR's main additions: the validator, its tests, and the CI workflow. Record those additions so the new changelog accurately describes the release.
- Added `docs/architecture.md` documenting repository components, validation pipeline, and a code-derived dependency graph.
- Added `CONTRIBUTING.md` with contribution workflow and validation requirements.
validate_pocs.py:453
--rootaccepts nonexistent paths and regular files, butvalidate_repothen reachesroot.iterdir()and terminates with an uncaught exception. Validate the CLI argument first so this user error produces a controlled diagnostic and exit code.
result = validate_repo(args.root.resolve())
…phic-blueprint Merge pull request #36 from 5hy7xz92nd-oss/main
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
Suppressed comments (9)
CONTRIBUTING.md:45
- Bash is a required validator executable:
_validate_shell_scripts()fails when it is absent. Add it to the dependency notes so the documented prerequisites match what contributors must install.
- Python 3.11+ is required for repository validation.
- Node.js is required for JavaScript syntax checks.
- PoC-specific dependencies should be documented in each entry's `README.md`.
validate_pocs.py:372
- This sanity check counts repository-level tooling such as
validate_pocs.pyitself. Because that file is always returned bydiscover_python_targets(),discoveredis nonzero even when every file inside every PoC directory was skipped, so the advertised fail-closed path never runs. Count only targets beneathpoc_dirsand add a fixture where PoC files exist but discovery excludes them.
discovered = (
len(python_targets)
+ len(package_targets)
+ len(cargo_targets)
+ len(requirements_targets)
+ len(javascript_targets)
+ len(json_targets)
+ len(shell_targets)
+ len(sha256_targets)
)
validate_pocs.py:170
- A Cargo virtual workspace is a valid
Cargo.tomlwith[workspace]and no[package], but this validator reports it as invalid even though discovery accepts every Cargo manifest. Accept virtual workspace manifests (and cover one in the fixture tests), or explicitly restrict discovery to package manifests.
package = data.get("package")
if not isinstance(package, dict):
errors.append(f"{path.relative_to(root)}: missing [package] table")
continue
.github/instructions/*.instructions.md:1
- This file is a 1,487-line pasted conversation/diagram rather than repository-specific coding guidance. Content under
.github/instructionscan be supplied to coding agents, so this adds substantial irrelevant and untrusted chat/link context instead of actionable instructions. Remove this file or replace it with concise project guidance.
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
README.md:54
- The dependency list omits Bash, although validation fails when
bashis unavailable and uses it for every*.shfile. This makes the documented local prerequisites incomplete, especially on Windows.
- **Python 3.11+** (CI uses 3.12): required for `validate_pocs.py` and unit tests (`tomllib` is used from the standard library).
- **Node.js** (`node --check`): required by `validate_pocs.py` to syntax-check JavaScript PoC files.
- **No third-party Python package is required** for repository-level validation.
docs/architecture.md:62
- The runtime dependency list omits Bash even though
_validate_shell_scripts()treats a missingbashexecutable as a validation error. Document it alongside Python and Node.
- Python 3.11+ (uses `tomllib` from stdlib; CI pins 3.12)
- Node.js for JavaScript syntax checks (`node --check`)
- No third-party Python dependencies for repository validation
CONTRIBUTING.md:39
- The contributor-facing checklist omits the newly added shell-script and checksum-manifest validation. Contributors following this list can miss failures that
validate_pocs.pyand CI will enforce.
This issue also appears on line 43 of the same file.
- JavaScript syntax via `node --check`
- Per-entry `README.md` presence
- Root catalog consistency in `/README.md`
CHANGELOG.md:10
- This changelog says all repository-level validation changes are tracked, but the Unreleased section omits the primary additions in this PR: the validator, its test suite, and the CI workflow. Record those additions so the changelog reflects the release contents.
### Added
- Added `docs/architecture.md` documenting repository components, validation pipeline, and a code-derived dependency graph.
- Added `CONTRIBUTING.md` with contribution workflow and validation requirements.
README.md:24
- The PR title and description do not describe the validator, tests, CI workflow, checksum updates, or documentation introduced here, so reviewers cannot derive the intended scope or acceptance criteria from the PR metadata. Update the title and description to summarize these repository-validation changes.
## Project architecture
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
Suppressed comments (7)
CONTRIBUTING.md:45
- Contributors are instructed to run the validator, but this dependency list omits Bash, whose absence causes validation to fail whenever shell targets exist. Document it explicitly.
- Python 3.11+ is required for repository validation.
- Node.js is required for JavaScript syntax checks.
- PoC-specific dependencies should be documented in each entry's `README.md`.
validate_pocs.py:201
- This predicate only rejects option-like lines that contain no alphanumeric characters. Arbitrary invalid entries such as
not a valid requirementor!!!therefore pass, so the new integrity gate reports malformed requirements files as valid. Parse requirement specifiers with a real PEP 508 parser (while handling supported pip options separately), or narrow the documented contract to the emptiness check actually performed.
for line in meaningful:
if line.startswith("-") and not any(ch.isalnum() for ch in line):
errors.append(f"{path.relative_to(root)}: invalid requirement line: {line!r}")
validate_pocs.py:453
- A nonexistent or non-directory
--rootreachesroot.iterdir()and produces an uncaught traceback instead of a CLI validation error. Validate the argument before callingvalidate_repo.
result = validate_repo(args.root.resolve())
README.md:54
- The repository validator fails when
bashis unavailable because shell scripts are always checked withbash -n, but the documented validation dependencies omit Bash. Add it so contributors—especially on Windows—know what is required to run the advertised commands.
- **Node.js** (`node --check`): required by `validate_pocs.py` to syntax-check JavaScript PoC files.
- **No third-party Python package is required** for repository-level validation.
docs/architecture.md:62
- The runtime dependency list omits Bash even though
_validate_shell_scriptstreats its absence as a validation failure. Document Bash alongside Node.js so this architecture reference matches the validator contract.
- Python 3.11+ (uses `tomllib` from stdlib; CI pins 3.12)
- Node.js for JavaScript syntax checks (`node --check`)
- No third-party Python dependencies for repository validation
CONTRIBUTING.md:39
- This list claims to describe what
validate_pocs.pychecks, but it omits the newly implemented shell syntax and checksum-manifest validation. Add both so contributors understand why validation may fail.
This issue also appears on line 43 of the same file.
- JavaScript syntax via `node --check`
- Per-entry `README.md` presence
- Root catalog consistency in `/README.md`
CHANGELOG.md:10
- The changelog says all notable validation changes are tracked, but the Unreleased section omits this PR's principal additions: the validator, its tests, and the CI workflow. Record them here so the changelog accurately describes the release.
- Added `docs/architecture.md` documenting repository components, validation pipeline, and a code-derived dependency graph.
- Added `CONTRIBUTING.md` with contribution workflow and validation requirements.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
Suppressed comments (11)
validate_pocs.py:1
- The PR title and description do not describe this validator, CI workflow, documentation, or checksum work, so the stated purpose is materially disconnected from the implementation. Update the PR metadata to summarize the repository-validation change and its scope.
#!/usr/bin/env python3
.github/instructions/*.instructions.md:1
- The literal
*in this tracked filename is invalid on Windows, so Git for Windows cannot check out the repository. Rename or remove the file; if these are intended as path-specific instructions, use a concrete filename such asreview.instructions.md.
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
validate_pocs.py:453
--rootis accepted without validation, but a missing or non-directory path reachesroot.iterdir()and produces a traceback. Validate the argument before callingvalidate_reposo CLI users receive an actionable parser error.
result = validate_repo(args.root.resolve())
validate_pocs.py:372
- This sanity check counts repository-level targets, including
validate_pocs.pyitself, sodiscoveredis always nonzero in this repository even if discovery skips every file inside every PoC directory. Count only targets beneathpoc_dirs; otherwise the advertised fail-closed check cannot detect the failure it was added for.
discovered = (
len(python_targets)
+ len(package_targets)
+ len(cargo_targets)
+ len(requirements_targets)
+ len(javascript_targets)
+ len(json_targets)
+ len(shell_targets)
+ len(sha256_targets)
)
validate_pocs.py:112
- The catalog regex is applied to the entire README, so any unrelated Markdown table row whose first cell is code-formatted is interpreted as a PoC directory and causes a false “missing directory” error. Restrict parsing to the
## Contentscatalog table and add a regression fixture containing another table.
def parse_readme_catalog(readme_text: str) -> List[str]:
return CATALOG_ROW_RE.findall(readme_text)
.github/instructions/*.instructions.md:494
- This section is copied PR review output rather than repository guidance, and the surrounding file repeats discussion/transcript content for 1,487 lines. Keeping that material under
.github/instructionsadds unrelated data and risks feeding stale review text to instruction-aware tooling; remove it or replace it with concise, valid project instructions.
Pull request overview
This pull request adds a repository-level validator to sanity-check PoC-related entrypoints/manifests (Python syntax compilation and package.json scripts.poc shape), along with a small unittest suite to exercise discovery/validation behavior.
Changes:
Add validate_pocs.py to discover Python files and package.json manifests and validate them (compile/JSON/scripts checks).
README.md:54
- The local dependency list omits Bash even though validation fails when
bashis unavailable and uses it for every shell script. Add Bash explicitly so the documented prerequisites match the validator.
- **Python 3.11+** (CI uses 3.12): required for `validate_pocs.py` and unit tests (`tomllib` is used from the standard library).
- **Node.js** (`node --check`): required by `validate_pocs.py` to syntax-check JavaScript PoC files.
- **No third-party Python package is required** for repository-level validation.
docs/architecture.md:62
- The runtime dependency list omits Bash, although
_validate_shell_scriptstreats a missingbashexecutable as a validation failure. Document Bash alongside Python and Node.
- Python 3.11+ (uses `tomllib` from stdlib; CI pins 3.12)
- Node.js for JavaScript syntax checks (`node --check`)
- No third-party Python dependencies for repository validation
CONTRIBUTING.md:45
- Contributors are told to run the validator, but this prerequisite list omits Bash even though the command fails without it. Add Bash to keep the setup instructions complete.
- Python 3.11+ is required for repository validation.
- Node.js is required for JavaScript syntax checks.
- PoC-specific dependencies should be documented in each entry's `README.md`.
validate_pocs.py:391
- “Validateable” is misspelled; use “validatable” in this diagnostic.
"discovery returned no validateable files despite PoC content on disk; "
CHANGELOG.md:10
- The changelog says it tracks all repository-level validation changes, but the main additions—
validate_pocs.py, its test suite, and the CI workflow—are absent fromUnreleased. Record them so this release history reflects the functional changes rather than only the accompanying documentation.
- Added `docs/architecture.md` documenting repository components, validation pipeline, and a code-derived dependency graph.
- Added `CONTRIBUTING.md` with contribution workflow and validation requirements.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
Suppressed comments (9)
validate_pocs.py:1
- The PR title and description do not describe this validator, CI, and documentation change, so reviewers cannot verify the intended scope. Please replace the metadata with a concise purpose, change summary, and validation expectations.
#!/usr/bin/env python3
.github/instructions/*.instructions.md:1
- This cannot serve as path-scoped Copilot guidance: these files require
applyToYAML frontmatter, but the body starts with a pasted PR transcript. The literal*filename also prevents checkout on Windows. Delete this accidental file, or rename it to a portableNAME.instructions.mdand replace it with concise scoped guidance plus the required frontmatter.
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
CONTRIBUTING.md:45
- Contributors running the required validator also need Bash; without it validation returns an error. Add Bash to these dependency notes.
- Python 3.11+ is required for repository validation.
- Node.js is required for JavaScript syntax checks.
- PoC-specific dependencies should be documented in each entry's `README.md`.
README.md:54
- The validator fails when
bashis unavailable (validate_pocs.py:229-232), but this dependency list omits it. Add Bash so the documented local prerequisites are complete.
- **Python 3.11+** (CI uses 3.12): required for `validate_pocs.py` and unit tests (`tomllib` is used from the standard library).
- **Node.js** (`node --check`): required by `validate_pocs.py` to syntax-check JavaScript PoC files.
- **No third-party Python package is required** for repository-level validation.
docs/architecture.md:62
- This tooling list omits Bash even though
_validate_shell_scriptstreats a missingbashexecutable as a validation error. Document it alongside Python and Node.
- Python 3.11+ (uses `tomllib` from stdlib; CI pins 3.12)
- Node.js for JavaScript syntax checks (`node --check`)
- No third-party Python dependencies for repository validation
CONTRIBUTING.md:39
- This checklist omits two checks that the validator now enforces: shell syntax and
SHA256SUMS.txtintegrity. Contributors can otherwise follow the documented requirements and still fail validation after changing either artifact type.
This issue also appears on line 43 of the same file.
- JavaScript syntax via `node --check`
- Per-entry `README.md` presence
- Root catalog consistency in `/README.md`
CHANGELOG.md:10
- The changelog says all notable validation changes are tracked, but the Unreleased section omits this PR's main additions: the validator, its test suite, and the CI workflow. Record them so the changelog matches its stated scope.
- Added `docs/architecture.md` documenting repository components, validation pipeline, and a code-derived dependency graph.
- Added `CONTRIBUTING.md` with contribution workflow and validation requirements.
validate_pocs.py:170
- A Cargo virtual-workspace manifest is valid with
[workspace]and no[package], but every such manifest is reported as invalid here. Accept a top-level workspace table when the package table is absent, and add a workspace fixture so valid multi-crate PoCs can pass this repository gate.
package = data.get("package")
if not isinstance(package, dict):
errors.append(f"{path.relative_to(root)}: missing [package] table")
continue
validate_pocs.py:175
- Cargo workspace members may validly inherit
package.version(andpackage.editionbelow) using{ workspace = true }; requiring strings rejects those valid manifests. Support the inherited form in addition to explicit strings and cover both forms in the Cargo fixtures.
for field in ("name", "version"):
value = package.get(field)
if not isinstance(value, str) or not value.strip():
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Suppressed comments (8)
validate_pocs.py:42
- A symlink whose target is outside
rootmakesrelative_to()raise here, but the fallback returns its lexical path parts and leaves it discoverable. A pull request can therefore add a*.py/JSON/etc. symlink that makes CI read a host file outside the checkout. Treat paths that resolve outside the repository as excluded.
try:
return path.resolve().relative_to(root.resolve()).parts
except ValueError:
return path.parts
CONTRIBUTING.md:45
- Contributors are not told that Bash is required, although the documented validation command fails when shell targets exist and Bash is unavailable (
validate_pocs.py:225-232). Add Bash to the prerequisite list.
- Python 3.11+ is required for repository validation.
- Node.js is required for JavaScript syntax checks.
- PoC-specific dependencies should be documented in each entry's `README.md`.
validate_pocs.py:387
- This sanity scan ignores the same exclusion rules used by discovery. For example, a PoC containing only
node_modules/generated.jsproduces zero discovered targets but a nonzeroon_disk, so validation fails even thoughnode_modulesis intentionally excluded. Filter these fallback scans through_is_excluded.
on_disk += _count_files(poc_dir.rglob("*.py"))
on_disk += _count_files(poc_dir.rglob("package.json"))
on_disk += _count_files(poc_dir.rglob("Cargo.toml"))
on_disk += _count_files(poc_dir.rglob("requirements*.txt"))
on_disk += _count_files(poc_dir.rglob("*.js"))
README.md:54
- The dependency list omits Bash even though validation returns an error whenever shell targets exist and
bashis unavailable (validate_pocs.py:225-232). List Bash so the documented local prerequisites are sufficient to run the advertised validation command.
- **Python 3.11+** (CI uses 3.12): required for `validate_pocs.py` and unit tests (`tomllib` is used from the standard library).
- **Node.js** (`node --check`): required by `validate_pocs.py` to syntax-check JavaScript PoC files.
- **No third-party Python package is required** for repository-level validation.
docs/architecture.md:62
- Bash is a required validator runtime whenever
*.shfiles are present (validate_pocs.py:225-232), but it is absent from this dependency list. Add it so the architecture's runtime contract matches the implementation.
- Python 3.11+ (uses `tomllib` from stdlib; CI pins 3.12)
- Node.js for JavaScript syntax checks (`node --check`)
- No third-party Python dependencies for repository validation
CONTRIBUTING.md:39
- This list omits two checks that the command performs:
bash -nvalidation andSHA256SUMS.txtintegrity verification. Contributors can otherwise miss prerequisites and checksum failures described elsewhere in the same PR; include both checks here.
This issue also appears on line 43 of the same file.
`validate_pocs.py` checks:
- Python syntax for tracked `*.py`
- `package.json` and generic `*.json` parse validity
- `Cargo.toml` shape for package metadata
- `requirements*.txt` has meaningful dependency entries
- JavaScript syntax via `node --check`
- Per-entry `README.md` presence
- Root catalog consistency in `/README.md`
CHANGELOG.md:10
- The changelog says all notable validation changes are tracked, but the Added section omits this PR's primary additions: the validator, its tests, and the CI workflow. Record these so the Unreleased entry accurately summarizes the release-level changes.
- Added `docs/architecture.md` documenting repository components, validation pipeline, and a code-derived dependency graph.
- Added `CONTRIBUTING.md` with contribution workflow and validation requirements.
.github/instructions/*.instructions.md:490
- This instructions file contains a copied pull-request transcript and repeated diagrams rather than actionable repository guidance. Because files under
.github/instructionsare consumed as Copilot context, this large unrelated transcript pollutes automated coding/review prompts and can produce inconsistent output. Remove it or replace it with concise, repository-specific instructions.
Copilot AI reviewed last week
Copilot AI
left a comment
Pull request overview
This pull request adds a repository-level validator to sanity-check PoC-related entrypoints/manifests (Python syntax compilation and package.json scripts.poc shape), along with a small unittest suite to exercise discovery/validation behavior.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.
Suppressed comments (10)
validate_pocs.py:375
- This sanity check counts every repository target, including
validate_pocs.pyitself. In the real checkoutdiscoveredis therefore always nonzero, so the check cannot detect when all PoC files were skipped by the exclusion rules. Count only targets beneath the discovered PoC directories.
discovered = (
validate_pocs.py:204
- This predicate does not validate requirement syntax: almost every malformed line containing a letter or digit passes (for example,
not a valid requirement ???), and an option-only file is treated as containing dependencies. As a result, invalid requirements manifests can pass the new integrity gate. Parse PEP 508 requirements and explicitly handle supported pip directives/includes.
for line in meaningful:
if line.startswith("-") and not any(ch.isalnum() for ch in line):
errors.append(f"{path.relative_to(root)}: invalid requirement line: {line!r}")
validate_pocs.py:301
read_bytes()can raiseOSErrorfor an unreadable or concurrently removed checksum target. That exception currently aborts the entire validator instead of reporting the file alongside the other accumulated validation errors.
actual_hash = hashlib.sha256(target.read_bytes()).hexdigest()
.github/instructions/*.instructions.md:1
- This instructions file contains a copied pull-request timeline, repeated diagrams, mentions, and an external chat link rather than repository coding guidance. Keeping 1,487 lines of transient conversation under
.github/instructionscan be ingested as Copilot context and makes the repository instructions unusable. Remove this file or replace it with concise, actionable project instructions.
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
README.md:53
- The repository dependency list omits Bash even though the validator fails whenever shell targets exist and
bashis unavailable (validate_pocs.py:228-235). Add Bash so Windows and minimal-environment users know the documented local command requires it.
- **Node.js** (`node --check`): required by `validate_pocs.py` to syntax-check JavaScript PoC files.
docs/architecture.md:61
- This runtime dependency list omits Bash, although the validator treats a missing
bashexecutable as a validation error whenever*.shfiles are present (validate_pocs.py:228-235).
- Node.js for JavaScript syntax checks (`node --check`)
CONTRIBUTING.md:44
- Bash is also a required local validation dependency: repositories with shell targets fail validation when
bashis unavailable (validate_pocs.py:228-235). Document it here with the other required tools.
- Node.js is required for JavaScript syntax checks.
CHANGELOG.md:10
- The changelog says repository-level validation changes are tracked, but the main additions in this PR—the validator, its tests, and the validation workflow—are absent from the Unreleased section. Record them so the changelog reflects the actual functional change rather than only its documentation.
- Added `docs/architecture.md` documenting repository components, validation pipeline, and a code-derived dependency graph.
- Added `CONTRIBUTING.md` with contribution workflow and validation requirements.
validate_pocs.py:304
- The tests cover a valid checksum plus malformed and escaping entries, but never an existing file with a wrong digest. Without that case, removing or breaking this comparison would still leave the suite green. Add a fixture with a valid-format incorrect hash and assert the checksum-mismatch error.
if not hmac.compare_digest(actual_hash, expected_hash.lower()):
errors.append(
f"{path.relative_to(root)}: checksum mismatch for {relative_name!r}"
CONTRIBUTING.md:39
- This contributor-facing list omits the newly enforced shell syntax and checksum-manifest checks, so contributors may not realize those artifacts can fail the required command. Include both checks described in the root README and validator.
- JavaScript syntax via `node --check`
- Per-entry `README.md` presence
- Root catalog consistency in `/README.md`
PATPAT WEAREOne10BILLION MANUSWEAREOne10BILLIONPAT PATWEAREONE10BILLIONMANUSPATWEAREONE10BILLIONMANUSGOLDENRABBITDRAGON ASYNC FUSE LINK SOLID