Copilot/sync rabbit data - #23
Conversation
…test-run-develop-repeat Add repository-wide PoC validation and regression coverage
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
…phic-blueprint
…ck-merge-into-13
…zed-architecture
…evelopment-101
…9037156-5ff9ba77-5a95-4efd-94b2-b543e449f694
Agent-Logs-Url: https://github.com/5hy7xz92nd-oss/exploitarium/sessions/f54d71c7-dd80-44db-b19c-a02b8d851ee0 Co-authored-by: 5hy7xz92nd-oss <249378113+5hy7xz92nd-oss@users.noreply.github.com>
…037156-cd7955bc-0ce9-4309-a99a-81995eb4a0b5
…9037156-6ffb0e1d-9205-49bd-9569-d81b97ec3e6c
…phic-blueprint
…9037156-6ffb0e1d-9205-49bd-9569-d81b97ec3e6c
There was a problem hiding this comment.
Pull request overview
This pull request introduces a small repository validator to sanity-check PoC-related entrypoints/manifests (Python syntax compilation + package.json validation) and adds a corresponding unit test, alongside a new GitHub Copilot instructions file under .github/instructions.
Changes:
- Add
validate_pocs.pyto discover/validate Python files andpackage.jsonmanifests and provide a CLI entrypoint. - Add
tests/test_validate_pocs.pyto cover discovery and “repo validates cleanly”. - Add a Copilot instructions markdown file under
.github/instructions.
Reviewed changes
Copilot reviewed 3 out of 17 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
validate_pocs.py |
New validator script for compiling Python files and validating package.json content. |
tests/test_validate_pocs.py |
Adds unittest coverage for discovery and clean validation. |
.github/instructions/*.instructions.md |
Adds Copilot custom instructions content (currently includes problematic filename/content). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 17 changed files in this pull request and generated no new comments.
Suppressed comments (3)
validate_pocs.py:11
- Unused import: Tuple is imported but never referenced, which will trip linters and adds noise.
from typing import List, Dict, Tuple
tests/test_validate_pocs.py:18
- This test is brittle because it hard-codes a specific repo file (run_demo.py) and a minimum total Python file count. Either change could fail the suite even if discovery still works correctly.
self.assertTrue(any(path.name == "run_demo.py" for path in python_targets))
self.assertTrue(any(path.name == "package.json" for path in package_targets))
self.assertGreater(len(python_targets), 20)
self.assertGreater(len(package_targets), 0)
.github/instructions/*.instructions.md:5
- This Copilot instructions file appears to be a large pasted conversation/ASCII-art block (and includes external links/mentions), which will add significant noise and token cost to automated reviews. Also, the literal
*in the filename can break tooling on some platforms and complicate glob-based scripts. Consider removing this content and replacing it with concise, repo-relevant instructions under a normal filename (e.g.,code-review.instructions.md).
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
👁️ Observer
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 17 changed files in this pull request and generated no new comments.
Suppressed comments (4)
validate_pocs.py:11
Tupleis imported but never used; this can trigger lint/type-check failures and makes the module look unfinished. Remove the unused import (or use it if intended).
from typing import List, Dict, Tuple
tests/test_validate_pocs.py:18
- This test is brittle: asserting
len(python_targets) > 20will fail as the repo grows/shrinks even when discovery is correct. Prefer only asserting non-empty discovery and/or presence of a stable known target.
self.assertTrue(any(path.name == "run_demo.py" for path in python_targets))
self.assertTrue(any(path.name == "package.json" for path in package_targets))
self.assertGreater(len(python_targets), 20)
self.assertGreater(len(package_targets), 0)
.github/instructions/*.instructions.md:5
- This new Copilot instructions file appears to contain large amounts of non-instructional/log-like content (mentions, repeated ASCII art, and external chat links). Keeping this in
.github/instructionsrisks prompt-injection style behavior and makes repository instructions hard to review and maintain. Consider removing it, or replacing it with a short, task-focused set of instructions under a normal filename (avoid*in filenames, which breaks checkouts on Windows/filesystems that disallow it).
@5hy7xz92nd-oss @copilot @copilot @copilot @we-tech-company @copilot @5hy7xz92nd-oss 🕴️🔃〰️⤴️@copilot🌎 REALITY
|
↓
👁️ Observer
|
validate_pocs.py:14
discover_*_targets()only excludes.gitand__pycache__, so it will also traverse common local/CI artifact directories likenode_modules/and virtualenvs (several PoC folders already ignore.venv/venvandnode_modulesin their.gitignore). This can significantly slow validation and may surface irrelevant errors from installed dependencies. ExpandEXCLUDED_DIRSto skip those artifact directories.
EXCLUDED_DIRS = {".git", "__pycache__"}
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 17 changed files in this pull request and generated no new comments.
Suppressed comments (2)
validate_pocs.py:11
Tupleis imported but never used, which can trigger linter failures and adds noise to the module imports.
from typing import List, Dict, Tuple
tests/test_validate_pocs.py:18
- These tests are coupled to the current repository contents (expects specific filenames and minimum counts, and asserts the whole repo validates cleanly). This will become flaky as PoCs are added/removed or if the repo intentionally contains non-compiling examples; prefer testing against a temporary directory fixture with controlled files.
self.assertTrue(any(path.name == "run_demo.py" for path in python_targets))
self.assertTrue(any(path.name == "package.json" for path in package_targets))
self.assertGreater(len(python_targets), 20)
self.assertGreater(len(package_targets), 0)
No description provided.