feat: show incoming warnings as stylized icons instead of text - #17
Merged
Conversation
Trial: replace the big auto-fit text label in the incoming-warning screen with a stylized pictogram per warning type, drawn from plain U8g2 vector primitives (no bitmap assets). The original short label is kept as a small caption underneath so meaning stays unambiguous while riders learn the icons. Display-only change, no wire-format bytes touched -- no kVersion bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WarningType(car behind, hazard triangle, stop octagon, regroup people, attention ring+bang), drawn with plain U8g2 vector primitives -- no bitmap/XBM assets introduced.HAZARD AHEAD) is kept as a small caption under the icon so meaning stays unambiguous while riders learn the icons.kWarningFontLadder/splitLabelInTwo), shrinking the firmware slightly.incoming-warningmockup SVG and updates its description indocs/ui-mockups.md.Display-only change -- no wire-format bytes touched, so no
Protocol::kVersionbump.Test plan
pio runbuilds successfullypio test -e native-- all 78 cases passATTENTIONgesture, confirm each icon + caption renders correctly on the receiver and short-click still dismisses