fix(profile): align @username and Joined-date baselines - #851
Merged
github-actions[bot] merged 1 commit intoAug 29, 2026
Merged
Conversation
…ader Visitor feedback on /profiles/mao: the @username and "Joined <date>" badge looked misaligned. Their shared flex row used items-center, so the smaller "Joined" text (fixed text-xs) was centered against the taller @username line-height (which grows to md:text-lg), pulling it visibly below the username's baseline. Switch to items-baseline — the same convention already used for this pattern in ProfileCard.tsx.
github-actions
Bot
deleted the
fix/profile-header-username-joined-alignment
branch
August 29, 2026 18:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/profiles/mao, pointing atp.break-all.text-sm(@mao) andspan.inline-flex.items-center(Joined Aug 2025): "these two elements look misaligned and ugly."src/components/profile/ProfileLayout.tsx) useditems-center. The username text grows across breakpoints (text-sm→sm:text-base→md:text-lg) while the "Joined" badge stays fixed attext-xs, so centering by box height visibly dropped the smaller text below the username's baseline.items-center→items-baselineon the row, matching the same name+meta-text pattern already used insrc/components/ui/ProfileCard.tsx. One-line change, no other layout touched.Test plan
npx tsc --noEmit— cleannpx eslint src/components/profile/ProfileLayout.tsx— cleannpm run test:unit(2636 tests) and full pre-push suite — greenJoined Aug 2025now sits on the same text baseline as@maoinstead of hanging below it. Screenshot evidence kept in the session log; not committed (route was never part of the diff)./profiles/maopage against production data — this sandbox has no reachable Supabase credentials, so real-profile SSR isn't exercisable here (unrelated to this change).🤖 Generated with Claude Code