fix(messages): make New Message modal full-screen below md - #853
Merged
github-actions[bot] merged 1 commit intoAug 29, 2026
Conversation
Visitor feedback on /messages at 320x800: the New Message modal's search-result rows shared screen space with the fixed mobile bottom nav and Ask Cat FAB in the bottom-right corner, at risk of losing taps to whichever fixed control a row happened to land under. The centered card (max-w-md, backdrop padding) left a corridor at the bottom of short/narrow viewports where fixed chrome and modal content occupied the same coordinates. Below md, the modal is now a full-bleed sheet (h-full w-full, no rounding/border/backdrop padding) that covers the entire viewport — nothing renders where fixed chrome could steal a tap. The results list fills the remaining height and reserves safe-area-inset-bottom so the last row also clears a device's home indicator. md+ (tablet/desktop) is unchanged — verified pixel-identical card position/size/radius/border before and after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://orangecat.ch/messagesat 320×800: the New Message modal's search-result rows shared screen space with the fixed mobile bottom nav and the "Ask Cat" FAB in the bottom-right corner — at risk of a tap landing on whichever fixed control happened to be under a row instead of the row itself.main—NewConversationModal's backdrop (z-modal= 55) legitimately outranks bothMobileBottomNav(inlinezIndex: 45) and the Ask Cat FAB (z-40) in the same stacking context (no ancestor of the modal sets a transform/filter/etc. that would trap it in a lower stacking context). I built a full integration reproduction — the realMessagePanel/NewConversationModal/MobileBottomNav/GlobalCatLaunchercomponents, real classNames, a faked Supabase session via the Zustand auth store (this sandbox has no live credentials) — and at every coordinate matching the visitor's exact reported rects,elementFromPointresolved to the modal's own content, not the nav or FAB. Detail in the session handoff.max-w-mdcard with backdrop padding leaves the fixed nav/FAB corner sharing the same screen coordinates as the bottom of the results list — and the FleetCrown feedback-widget FAB (external, not in this repo, alwaysz-index: 2147483000) genuinely can't be beaten by any z-index we set, so that corner is never fully safe while any content renders there.md(768px, the same breakpointMessagePanelalready uses for its own mobile/desktop layout split), the modal is now a full-bleed sheet —h-full w-full, no rounding/border, no backdrop padding — covering the entire viewport. Nothing renders where fixed chrome could ever intercept a tap. The results list fills the remaining height (flex-1) and reservesenv(safe-area-inset-bottom)so the last row also clears a device's home-indicator/gesture-bar inset.md+ (tablet/desktop) is untouched.Test plan
npx tsc --noEmit— cleannpx eslint src/components/messaging/NewConversationModal.tsx— cleannpm run test:unit(2638 tests) and full pre-push suite — greenMessagePanel/NewConversationModal/MobileBottomNav/GlobalCatLauncher,/api/profilesmocked with 10 fake rows, real auth faked via the Zustand store since no live Supabase credentials exist in this sandbox): before the fix, the modal card ended around y676 leaving the fixed nav (y719-800) and FAB (y664-720) exposed underneath; after the fix, the card is exactly{x:0,y:0,w:320,h:800}and every previously-exposed coordinate — the old FAB center, the old nav center, the viewport's bottom-right corner — now resolves to real modal row content, not the nav or FAB.md+ (1024×768) is pixel-identical to before: card{x:288,y:113,w:448,h:542},border-radius:6px,border-width:1px— matches the originalmax-w-md rounded-md bordertreatment exactly.~/.fleetcrown/sessions/orangecat.md); the debug scaffolding used to reproduce this (a temp preview route, a tempwindow.__debugAuthStorehook, a temproutes.tsentry) was fully reverted before committing — this diff is exactly the one file above.🤖 Generated with Claude Code