Network Watch tool

[luke-jr]

Now that the crash bug (bitcoinknots/bitcoin#4) has been tracked down, this seems ready for re-opening for Core.

(Originally bitcoin/bitcoin#9849)

[jarolrod]

Concept ACK

In general, I'm in favor of not having tons of pop-out windows. May be worth exploring this as a new tab.

If possible, can you include screenshots of this in action in the OP?

[luke-jr]

Not sure how to add inline images on GitHub, but there's a sceenshot on the wiki: https://en.bitcoin.it/wiki/File:Bitcoinknots-netwatch.png

[luke-jr]

As for "pop out windows", I think that's the correct UX for features like this. Having a tab in the main window just doesn't seem to fit well.

Maybe a new debug-window-alike for statistics?

[jarolrod]

Have not yet reviewed the code, but:

Commit 47711fd must be broken off and opened in the core repo if it is needed. Then this can be based on the PR that would be open. The change to to validationinterface cannot be done in this repo.

Additionally, the commit history is not clean. The last 4 commits could be squashed onto ae6804e

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept NACK	rebroad
Concept ACK	jarolrod, jonatack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #553 (Change address / amount error background by w0xlt)
• #537 (Point out position of invalid characters in Bech32 addresses by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

[rebroad]

concept NACK - at least, so far, I'm struggling to understand the use case for this. I'd have thought something more command line would make sense, as surely there'd be so much data that it would scroll by too quickly to be useful.

[jonatack]

Concept ACK if I'm understanding from the earlier PR. Suggest describing what it does and the use case (what and why) in the pull description.

[DrahtBot]

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

[DrahtBot]

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

[DrahtBot]

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

[hebasto]

Closing this due to lack of activity. Feel free to reopen.