Modify command line help to show support for BIP21 URIs#752
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
Contributor
|
concept ACK |
jarolrod
approved these changes
Sep 12, 2023
luke-jr
reviewed
Sep 12, 2023
luke-jr
reviewed
Sep 12, 2023
hernanmarino
force-pushed
the
update-help-BIP21-URI
branch
from
b45658a to
07bb706
Compare
Contributor
Author
|
Updated to address @luke-jr and @pablomartin4btc |
luke-jr
reviewed
Nov 24, 2023
kristapsk
reviewed
Dec 27, 2023
hernanmarino
force-pushed
the
update-help-BIP21-URI
branch
from
07bb706 to
a63803a
Compare
hernanmarino
force-pushed
the
update-help-BIP21-URI
branch
from
a63803a to
ede5014
Compare
Contributor
Author
|
Fixed the 2 typos mentioned by @luke-jr and @kristapsk . Also rebased for CI. |
kristapsk
approved these changes
Feb 1, 2024
pablomartin4btc
left a comment
pablomartin4btc
left a comment
Contributor
There was a problem hiding this comment.
lgtm, re ACK ede5014
hebasto
approved these changes
Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing a different PR (see #742 ) hebasto suggested that the help for bitcoin-qt should be updated to reflect the fact that bitcoin-qt supports an optional BIP21 URI parameter.
Since this reflects actual behaviour of bitcoin-qt and is independent of whether or not the other PR gets merged, I created this simple PR to fix the help message.