ci: Bump channel to nixos-26.05#296
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
|
Some bumps:
I wonder if it makes sense to have an llvm-olddeps check here as well (mostly for capn 1.1), to check the full range, but this can be done in a follow-up. Looks loke olddeps fails anyway ... |
|
I am at a loss on reproducing and fixing the cmake 3.12 compile failure. Also, I don't see the point on wasting more time with ancient cmake versions that are only used by a single person, when #175 can be done, so I've included that here, to get the CI green. |
|
Ok, the failure seems to be: I used So I guess the alternative would be to pin olddeps to an older snapshot/channel, but this just seems tedious for little benefit. |
|
Thanks for the PR. The main change fa2c56e looks good but as discussed previously I don't think 34f48d1 is a good change because it is changing the cmake policy version and minimum version at the same time. These are two different concepts that have different effects and should not be coupled together, especially without even mentioning the policy changes in the commit message or PR description. If you believe it's important to trigger a fatal error that says cmake 3.22 is required (even though it is not required), I think you should do that without changing the policy version. Or you might consider just showing a warning that versions <= 3.22 are not supported. Or you might consider dropping the cmake change from this PR and leaving it for a dedicated PR. I also don't think the |
I think the discussion about CMake policies would benefit from starting with a few basic questions:
All previous changes in this repository, including 06e1045, 6902bfd, and 729ff16, do not provide details in that regard. |
|
I don't think there is a policy in 3.12->3.22 that affects libmul. However, if you want me to push something like this to #175, then I am happy to do that. Then, I can open a follow-up to remove the line again. |
Mostly to get more recent iwyu coverage (ref #294 (comment))