BIP-434: Add ref impl, mark complete / CI: add version check#2197
Merged
Conversation
ajtowns
force-pushed
the
202606-434-complete
branch
2 times, most recently
from
c7c9a67 to
f0af5ef
Compare
Contributor
Author
|
I'm assuming "Deployed" should wait until there are features on the network actively using this protocol. |
jonatack
added
the
BIP Update by Owner
jonatack
reviewed
Jun 11, 2026
jonatack
left a comment
jonatack
left a comment
Member
There was a problem hiding this comment.
Concept ACK, it looks like bitcoin/bitcoin#35221 contains the per-BIP3 required "comprehensive test vectors before they can be moved to Complete."
ajtowns
force-pushed
the
202606-434-complete
branch
from
f0af5ef to
b14d7c3
Compare
Member
|
Good idea to add the version check to the CI. In a separate PR, it could be good to add a check to ensure the Version header and the latest version in the changelog (if present) are the same. |
jonatack
reviewed
Jun 11, 2026
| } | ||
| if (defined $version and $version =~ m/^0+[.]/) { | ||
| if ($status eq "Complete" or $status eq "Deployed") { | ||
| die "$fn marked as $status despite pre-1.0 version ($version)"; |
Member
There was a problem hiding this comment.
- Version: 1.0.0
+ Version: 0.0.1$ ./scripts/buildtable.pl > devnull
bip-0434.md marked as Complete despite pre-1.0 version (0.0.1) at ./scripts/buildtable.pl line 234, <$F> line 13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.