ci: replace local plugin validation with reusable gh-actions workflow - #179
ci: replace local plugin validation with reusable gh-actions workflow#179withinfocus wants to merge 4 commits into
Conversation
bitwarden/gh-actions#856 lifted the Claude-material validation workflow and its scripts out of this repo and made gh-actions their only home. Remove the local copies and call the reusable workflow instead. - Delete .github/workflows/validate-plugins.yml and the entire scripts/ directory (bump-plugin-version, validate-marketplace, validate-plugin-structure, validate-version-bump, lib/path-sanitization). - Add .github/workflows/validate-ai.yml, a thin caller of bitwarden/gh-actions/.github/workflows/_validate-ai.yml, mirroring the existing review-code.yml pattern. - Update CLAUDE.md, CONTRIBUTING.md, and README.md to point contributors at the scripts' new home in gh-actions and note validation now runs in CI.
|
Claude Code is reviewing the changed Claude configuration... If this comment does not update with results, check the Actions log. |
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR removes the repo-local Secrets are passed through Actions expressions with no hardcoded credentials, the trigger is |
|
I've deleted the branch protection requirement around AI validation. Once this lands I can set the new path up for this workflow. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
The plugin's CONTRIBUTING.md still referenced the repository-root ./scripts/bump-plugin-version.sh, which this branch deletes. Point it at the helper's new home in bitwarden/gh-actions, matching the root docs. Bump bitwarden-init to 1.2.1 (PATCH) with a changelog entry per the repo's version-bump rule for plugin doc changes.
The 1.2.1 bump missed the README catalog row, which validate-marketplace cross-checks against marketplace.json. Bump it to match.
Fix the bump-plugin-version.sh command path to be runnable from a gh-actions checkout, and list the README plugin catalog among the files a bump touches (across both CONTRIBUTING files and CLAUDE.md).
1 participant
🎟️ Tracking
No Jira ticket. This is the ai-plugins side of bitwarden/gh-actions#856, which moved the Claude-material validation workflow and its scripts into
gh-actionsas their only home.📔 Objective
Now that
gh-actionsowns the validation workflow, this repo no longer needs its own copy. Remove the local copies and call the reusable workflow instead..github/workflows/validate-plugins.ymland the wholescripts/directory (bump-plugin-version,validate-marketplace,validate-plugin-structure,validate-version-bump,lib/path-sanitization)..github/workflows/validate-ai.yml, a thin caller ofbitwarden/gh-actions/.github/workflows/_validate-ai.yml@main, following the same shape as the existingreview-code.yml.CLAUDE.md,CONTRIBUTING.md, andREADME.mdat the scripts' new location and note that structure, marketplace, and version-bump validation now run in CI.Note for reviewers
If
validate-plugins.yml's job was a required status check onmain, branch protection needs updating to the new check name (Validate AI / Validate) — the old check name will no longer report.