fix: emit OTEL for hosted web search - #4
Open
bk-nvidia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex.tool_resultOTEL row when hosted Responses API web search completesresponse.output_item.addedtoresponse.output_item.doneargumentsandoutputWhy
Hosted web search is executed by the Responses API rather than the local tool registry, so it currently appears as a
WebSearchCallresponse item but not as a localcodex.tool_result. Sidecar consumers that only read OTEL cannot reliably count web-search tool executions without an OTEL event from this hosted path.Tests
cargo test --manifest-path /private/tmp/openai-codex-latest/codex-rs/Cargo.toml -p codex-core response_stream_logs_hosted_web_search_tool_result_without_query_contentcargo test --manifest-path /private/tmp/openai-codex-latest/codex-rs/Cargo.toml -p codex-core response_stream_records_last_model_feedback_ids