feat: consolidate deployment compose into root under --profile deploy (COW-976)#65
Closed
lgahdl wants to merge 2 commits into
Closed
Conversation
The by_uids endpoint returns [{order: {...}}] but the code was treating
it as a flat OrderbookOrder[]. This caused order.uid to be undefined,
so fetchOrderStatusByUids returned an empty map for all candidates,
preventing C2 from ever promoting candidateDiscreteOrders to discreteOrders.
Verify the { order } unwrap fix with a real HTTP server: 6 tests covering
correct uid→status mapping, executed amounts, multiple orders, HTTP errors,
and empty responses. Adds ponder/ponder:schema vitest stubs to resolve
virtual module imports without a running Ponder process.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
yvesfracari
reviewed
May 28, 2026
yvesfracari
left a comment
yvesfracari
left a comment
There was a problem hiding this comment.
Is that right, there is no docker compose diff here
There was a problem hiding this comment.
this is relative to other PR, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate
deployment/docker-compose.ymlinto the rootdocker-compose.ymlas a--profile deployprofile, eliminating the duplicate file. The defaultdocker compose updev-database behavior is unchanged.Changes
postgres-deployandponderservices to rootdocker-compose.ymlunderprofiles: [deploy]start-db.shfrom./static/to./deployment/static/(context is now repo root)deployment/docker-compose.ymldeployment/manage.shto reference../docker-compose.ymlwith--profile deploydocs/deployment.mdHow to Test
docker compose --profile deploy upand verify the deploy stack starts (postgres + ponder)docker compose up(no profile) and verify only the dev postgres starts as beforeChecklist
Breaking Changes
None —
docker compose --profile deploy upreplaces the olddocker compose -f deployment/docker-compose.yml up.Related Issues
COW-976