Fix inbox reply parent targeting#1207
Draft
thomaspblock wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Thomas Petersen <thomasp@squareup.com> Signed-off-by: Thomas Petersen <thomasp@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Inbox replies from grouped thread activity so the bottom composer replies to the selected item's existing parent/root thread instead of nesting under the latest activity item.
Before this change, an Inbox row whose selected item was the latest nested reply defaulted
parentEventIdtoitem.id, creating an unintended child reply under the latest comment. Now the default reply target is derived from the selected feed item's thread tags:replyparent tag;Tests
node --import ./desktop/test-loader.mjs --experimental-strip-types --test desktop/src/features/home/lib/inboxViewHelpers.test.mjspnpm --dir desktop typecheckpnpm --dir desktop checkpnpm --dir desktop test(1099/1099)pnpm --dir desktop buildpnpm --dir desktop exec playwright test tests/e2e/smoke.spec.ts --project=smoke --grep "inbox composer replies"Screenshots
Posted inline in
#buzz-bugswith the verification flow: