-
Notifications
You must be signed in to change notification settings - Fork 26
fix(desktop): prevent process text truncation #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thomaspblock
wants to merge
1
commit into
main
Choose a base branch
from
fix-bot-activity-text-truncation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| import { expect, test, type Page } from "@playwright/test"; | ||
|
|
||
| import { installMockBridge } from "../helpers/bridge"; | ||
| import { waitForAnimations } from "../helpers/animations"; | ||
|
|
||
| const SHOTS = "test-results/process-text"; | ||
| const AGENT_PUBKEY = "ab".repeat(32); | ||
| const AGENT_NAME = | ||
| "Brain process status with a deliberately long operation label that should ellipsize cleanly"; | ||
| const KIND_TYPING_INDICATOR = 20002; | ||
|
|
||
| async function waitForMockLiveSubscription( | ||
| page: Page, | ||
| channelName: string, | ||
| kind?: number, | ||
| ) { | ||
| await expect | ||
| .poll(async () => { | ||
| return page.evaluate( | ||
| ({ ch, k }) => | ||
| ( | ||
| window as Window & { | ||
| __BUZZ_E2E_HAS_MOCK_LIVE_SUBSCRIPTION__?: (input: { | ||
| channelName: string; | ||
| kind?: number; | ||
| }) => boolean; | ||
| } | ||
| ).__BUZZ_E2E_HAS_MOCK_LIVE_SUBSCRIPTION__?.({ | ||
| channelName: ch, | ||
| kind: k, | ||
| }) ?? false, | ||
| { ch: channelName, k: kind }, | ||
| ); | ||
| }) | ||
| .toBe(true); | ||
| } | ||
|
|
||
| async function seedMainBotTyping(page: Page) { | ||
| await waitForMockLiveSubscription(page, "general", KIND_TYPING_INDICATOR); | ||
| await page.evaluate((pubkey) => { | ||
| ( | ||
| window as Window & { | ||
| __BUZZ_E2E_EMIT_MOCK_TYPING__?: (input: { | ||
| channelName: string; | ||
| pubkey?: string; | ||
| }) => unknown; | ||
| } | ||
| ).__BUZZ_E2E_EMIT_MOCK_TYPING__?.({ channelName: "general", pubkey }); | ||
| }, AGENT_PUBKEY); | ||
| } | ||
|
|
||
| async function seedThreadBotTyping(page: Page) { | ||
| await page.evaluate((pubkey) => { | ||
| ( | ||
| window as Window & { | ||
| __BUZZ_E2E_EMIT_MOCK_MESSAGE__?: (input: { | ||
| channelName: string; | ||
| content: string; | ||
| kind?: number; | ||
| pubkey?: string; | ||
| extraTags?: string[][]; | ||
| }) => unknown; | ||
| } | ||
| ).__BUZZ_E2E_EMIT_MOCK_MESSAGE__?.({ | ||
| channelName: "general", | ||
| content: "", | ||
| kind: 20002, | ||
| pubkey, | ||
| extraTags: [["e", "mock-general-welcome", "", "reply"]], | ||
| }); | ||
| }, AGENT_PUBKEY); | ||
| } | ||
|
|
||
| test.describe("process text truncation screenshots", () => { | ||
| test.use({ viewport: { width: 960, height: 720 } }); | ||
|
|
||
| test.beforeEach(async ({ page }) => { | ||
| await installMockBridge(page, { | ||
| managedAgents: [ | ||
| { | ||
| pubkey: AGENT_PUBKEY, | ||
| name: AGENT_NAME, | ||
| status: "running", | ||
| channelNames: ["general"], | ||
| }, | ||
| ], | ||
| }); | ||
| await page.goto("/"); | ||
| await page.getByTestId("channel-general").click(); | ||
| await expect(page.getByTestId("chat-title")).toHaveText("general"); | ||
| }); | ||
|
|
||
| test("main composer process text ellipsizes", async ({ page }) => { | ||
| await seedMainBotTyping(page); | ||
| const trigger = page.getByTestId("bot-activity-composer-trigger"); | ||
| await expect(trigger).toBeVisible(); | ||
| await expect(trigger).toContainText("Working"); | ||
|
|
||
| await expect | ||
| .poll(async () => | ||
| trigger.evaluate((el) => { | ||
| const rect = el.getBoundingClientRect(); | ||
| const parent = el.parentElement?.getBoundingClientRect(); | ||
| return { | ||
| contained: parent | ||
| ? rect.left >= parent.left && rect.right <= parent.right + 1 | ||
| : false, | ||
| width: Math.round(rect.width), | ||
| parentWidth: parent ? Math.round(parent.width) : 0, | ||
| }; | ||
| }), | ||
| ) | ||
| .toMatchObject({ contained: true }); | ||
|
|
||
| await waitForAnimations(page); | ||
| await page.screenshot({ | ||
| path: `${SHOTS}/01-main-composer-process-text.png`, | ||
| clip: { x: 245, y: 590, width: 690, height: 105 }, | ||
| }); | ||
| }); | ||
|
|
||
| test("thread composer process text ellipsizes", async ({ page }) => { | ||
| await page.evaluate(() => { | ||
| ( | ||
| window as Window & { | ||
| __BUZZ_E2E_EMIT_MOCK_MESSAGE__?: (input: { | ||
| channelName: string; | ||
| content: string; | ||
| parentEventId?: string; | ||
| }) => unknown; | ||
| } | ||
| ).__BUZZ_E2E_EMIT_MOCK_MESSAGE__?.({ | ||
| channelName: "general", | ||
| content: "Initial thread reply so the thread panel can open", | ||
| parentEventId: "mock-general-welcome", | ||
| }); | ||
| }); | ||
|
|
||
| const threadSummary = page.getByTestId("message-thread-summary").first(); | ||
| await expect(threadSummary).toBeVisible(); | ||
| await threadSummary.click(); | ||
| await expect(page.getByTestId("message-thread-panel")).toBeVisible(); | ||
|
|
||
| await seedThreadBotTyping(page); | ||
| const panel = page.getByTestId("message-thread-panel"); | ||
| const trigger = panel.getByTestId("bot-activity-composer-trigger"); | ||
| await expect(trigger).toBeVisible(); | ||
| await expect(trigger).toContainText("Working"); | ||
|
|
||
| await expect | ||
| .poll(async () => | ||
| trigger.evaluate((el) => { | ||
| const rect = el.getBoundingClientRect(); | ||
| const parent = el.parentElement?.getBoundingClientRect(); | ||
| return { | ||
| contained: parent | ||
| ? rect.left >= parent.left && rect.right <= parent.right + 1 | ||
| : false, | ||
| width: Math.round(rect.width), | ||
| parentWidth: parent ? Math.round(parent.width) : 0, | ||
| }; | ||
| }), | ||
| ) | ||
| .toMatchObject({ contained: true }); | ||
|
|
||
| await waitForAnimations(page); | ||
| await page.screenshot({ | ||
| path: `${SHOTS}/02-thread-composer-process-text.png`, | ||
| clip: { x: 525, y: 565, width: 420, height: 135 }, | ||
| }); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomaspblock do we need the screenshot tests here for this one? It seems like it's adding code and test time, so I want to make sure it's useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still a draft. Will add video/screenshot once I am sure it works.