rs(deps): bump solana-sdk from 2.3.1 to 4.0.1 in /services-rs - #25
rs(deps): bump solana-sdk from 2.3.1 to 4.0.1 in /services-rs#25dependabot[bot] wants to merge 1 commit into
Conversation
behradkhodayar
left a comment
There was a problem hiding this comment.
Blocked by an upstream bug — cargo check --workspace against this branch fails inside solana-keypair 3.1.2 (a transitive dep that solana-sdk 4.0.1 pulls in):
```
error[E0277]: the trait bound DecodeError: std::error::Error is not satisfied
--> solana-keypair-3.1.2/src/lib.rs:53:9
|
53 | five8::decode_64(s, &mut buf).map_err(SignatureError::from_source)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: required for Box<(dyn std::error::Error + Send + Sync + 'static)> to implement From<DecodeError>
```
five8's DecodeError doesn't implement std::error::Error, which solana-keypair 3.1.2's from_source requires. This is an upstream solana crate issue — nothing for us to fix at this layer. Suggest leaving this PR closed (or letting Dependabot ignore the 4.x major) until solana-sdk releases a patch that pins a working solana-keypair / five8 combination.
Worth noting: we should keep this in mind — solana-sdk semver in the 3.x→4.x rebase has been bumpy across the whole ecosystem.
Bumps [solana-sdk](https://github.com/anza-xyz/solana-sdk) from 2.3.1 to 4.0.1. - [Release notes](https://github.com/anza-xyz/solana-sdk/releases) - [Commits](https://github.com/anza-xyz/solana-sdk/compare/sdk@v2.3.1...sdk@v4.0.1) --- updated-dependencies: - dependency-name: solana-sdk dependency-version: 4.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
8b1e3e2 to
4ce2182
Compare
Bumps solana-sdk from 2.3.1 to 4.0.1.
Release notes
Sourced from solana-sdk's releases.
Commits
b1bc122Publish solana-sdk v4.0.112b6316Publish solana-program v4.0.0029896dPublish solana-system-transaction v4.0.01cf4c97Publish solana-sdk v4.0.0318e685Publish solana-sdk-wasm-js v2.0.0e8b3cb3Publish solana-client-traits v4.0.093adcb0Publish solana-transaction v4.0.08dbac59Publish solana-nonce-account v4.0.04ca148ePublish solana-message v4.0.0883d8f4ci: Add run-semver option (#575)